Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: trunk/src/android_webview/native/java_browser_view_renderer_helper.cc

Issue 183003011: Revert 254567 "don't create SkDevice directly, use SkBitmap or (..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/android_webview/browser/browser_view_renderer.cc ('k') | trunk/src/cc/output/gl_renderer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/android_webview/native/java_browser_view_renderer_helper.cc
===================================================================
--- trunk/src/android_webview/native/java_browser_view_renderer_helper.cc (revision 254711)
+++ trunk/src/android_webview/native/java_browser_view_renderer_helper.cc (working copy)
@@ -10,6 +10,7 @@
#include "base/debug/trace_event.h"
#include "jni/JavaBrowserViewRendererHelper_jni.h"
#include "third_party/skia/include/core/SkBitmap.h"
+#include "third_party/skia/include/core/SkBitmapDevice.h"
#include "third_party/skia/include/utils/SkCanvasStateUtils.h"
using base::android::JavaRef;
@@ -155,12 +156,15 @@
bool succeeded;
{
- SkImageInfo info =
- SkImageInfo::MakeN32Premul(bitmap_info.width, bitmap_info.height);
SkBitmap bitmap;
- bitmap.installPixels(info, pixels, bitmap_info.stride);
+ bitmap.setConfig(SkBitmap::kARGB_8888_Config,
+ bitmap_info.width,
+ bitmap_info.height,
+ bitmap_info.stride);
+ bitmap.setPixels(pixels);
- SkCanvas canvas(bitmap);
+ SkBitmapDevice device(bitmap);
+ SkCanvas canvas(&device);
canvas.translate(-scroll_x, -scroll_y);
succeeded = renderer.Run(&canvas);
}
« no previous file with comments | « trunk/src/android_webview/browser/browser_view_renderer.cc ('k') | trunk/src/cc/output/gl_renderer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698