Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: trunk/src/android_webview/native/java_browser_view_renderer_helper.cc

Issue 183003011: Revert 254567 "don't create SkDevice directly, use SkBitmap or (..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/native/java_browser_view_renderer_helper.h" 5 #include "android_webview/native/java_browser_view_renderer_helper.h"
6 6
7 #include <android/bitmap.h> 7 #include <android/bitmap.h>
8 8
9 #include "android_webview/public/browser/draw_sw.h" 9 #include "android_webview/public/browser/draw_sw.h"
10 #include "base/debug/trace_event.h" 10 #include "base/debug/trace_event.h"
11 #include "jni/JavaBrowserViewRendererHelper_jni.h" 11 #include "jni/JavaBrowserViewRendererHelper_jni.h"
12 #include "third_party/skia/include/core/SkBitmap.h" 12 #include "third_party/skia/include/core/SkBitmap.h"
13 #include "third_party/skia/include/core/SkBitmapDevice.h"
13 #include "third_party/skia/include/utils/SkCanvasStateUtils.h" 14 #include "third_party/skia/include/utils/SkCanvasStateUtils.h"
14 15
15 using base::android::JavaRef; 16 using base::android::JavaRef;
16 using base::android::ScopedJavaLocalRef; 17 using base::android::ScopedJavaLocalRef;
17 18
18 namespace android_webview { 19 namespace android_webview {
19 20
20 namespace { 21 namespace {
21 22
22 // Provides software rendering functions from the Android glue layer. 23 // Provides software rendering functions from the Android glue layer.
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 } 149 }
149 150
150 void* pixels = NULL; 151 void* pixels = NULL;
151 if (AndroidBitmap_lockPixels(env, jbitmap.obj(), &pixels) < 0) { 152 if (AndroidBitmap_lockPixels(env, jbitmap.obj(), &pixels) < 0) {
152 LOG(ERROR) << "Error locking java bitmap pixels."; 153 LOG(ERROR) << "Error locking java bitmap pixels.";
153 return false; 154 return false;
154 } 155 }
155 156
156 bool succeeded; 157 bool succeeded;
157 { 158 {
158 SkImageInfo info =
159 SkImageInfo::MakeN32Premul(bitmap_info.width, bitmap_info.height);
160 SkBitmap bitmap; 159 SkBitmap bitmap;
161 bitmap.installPixels(info, pixels, bitmap_info.stride); 160 bitmap.setConfig(SkBitmap::kARGB_8888_Config,
161 bitmap_info.width,
162 bitmap_info.height,
163 bitmap_info.stride);
164 bitmap.setPixels(pixels);
162 165
163 SkCanvas canvas(bitmap); 166 SkBitmapDevice device(bitmap);
167 SkCanvas canvas(&device);
164 canvas.translate(-scroll_x, -scroll_y); 168 canvas.translate(-scroll_x, -scroll_y);
165 succeeded = renderer.Run(&canvas); 169 succeeded = renderer.Run(&canvas);
166 } 170 }
167 171
168 if (AndroidBitmap_unlockPixels(env, jbitmap.obj()) < 0) { 172 if (AndroidBitmap_unlockPixels(env, jbitmap.obj()) < 0) {
169 LOG(ERROR) << "Error unlocking java bitmap pixels."; 173 LOG(ERROR) << "Error unlocking java bitmap pixels.";
170 return false; 174 return false;
171 } 175 }
172 176
173 return succeeded; 177 return succeeded;
174 } 178 }
175 179
176 } // namespace android_webview 180 } // namespace android_webview
OLDNEW
« no previous file with comments | « trunk/src/android_webview/browser/browser_view_renderer.cc ('k') | trunk/src/cc/output/gl_renderer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698