third_party/WebKit/Source/platform/graphics/ColorSpace.cpp - Issue 1829093002: Use sk_sp-based APIs for SkColorFilter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/ColorSpace.cpp

Issue 1829093002: Use sk_sp-based APIs for SkColorFilter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Respond to reviews Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/graphics/ColorSpace.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/ColorSpace.cpp b/third_party/WebKit/Source/platform/graphics/ColorSpace.cpp

index 6ee8895479f4445561380546e7d1a09a6aae8770..89add3ca6c0b7652d1887ea775d8cef32af207ab 100644

--- a/third_party/WebKit/Source/platform/graphics/ColorSpace.cpp

+++ b/third_party/WebKit/Source/platform/graphics/ColorSpace.cpp

@@ -32,6 +32,7 @@

#include "platform/graphics/ColorSpace.h"

+#include "platform/graphics/skia/SkiaUtils.h"

#include "third_party/skia/include/effects/SkTableColorFilter.h"

#include "wtf/MathExtras.h"

#include <algorithm>

@@ -109,7 +110,7 @@ PassRefPtr<SkColorFilter> createColorSpaceFilter(ColorSpace srcColorSpace, Color

if (!lookupTable)

return nullptr;

- return adoptRef(SkTableColorFilter::CreateARGB(0, lookupTable, lookupTable, lookupTable));

+ return fromSkSp(SkTableColorFilter::MakeARGB(0, lookupTable, lookupTable, lookupTable));

}

} // namespace ColorSpaceUtilities