third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp - Issue 1829093002: Use sk_sp-based APIs for SkColorFilter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp

Issue 1829093002: Use sk_sp-based APIs for SkColorFilter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Respond to reviews Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp

diff --git a/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp b/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp

index 08849fd8cfd8a49c80a96b07756eb313d228435a..ef00df572f3eeadd5854e30b2051ead722b75cb3 100644

--- a/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp

+++ b/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp

@@ -295,7 +295,7 @@ void SVGImage::drawPatternForContainer(GraphicsContext& context, const FloatSize

paint.setShader(SkShader::MakePictureShader(toSkSp(tilePicture.release()),

SkShader::kRepeat_TileMode, SkShader::kRepeat_TileMode, &patternTransform, nullptr));

paint.setXfermodeMode(compositeOp);

- paint.setColorFilter(context.colorFilter());

+ paint.setColorFilter(sk_ref_sp(context.colorFilter()));

context.drawRect(dstRect, paint);

}