third_party/WebKit/Source/platform/graphics/DrawLooperBuilder.cpp - Issue 1829093002: Use sk_sp-based APIs for SkColorFilter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/DrawLooperBuilder.cpp

Issue 1829093002: Use sk_sp-based APIs for SkColorFilter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Respond to reviews Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/graphics/DrawLooperBuilder.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/DrawLooperBuilder.cpp b/third_party/WebKit/Source/platform/graphics/DrawLooperBuilder.cpp

index 3da44282bf502b7536508f7036aeefc10c47f8fc..632d0d3300209476aa46637a8d93a0a45e0b18c3 100644

--- a/third_party/WebKit/Source/platform/graphics/DrawLooperBuilder.cpp

+++ b/third_party/WebKit/Source/platform/graphics/DrawLooperBuilder.cpp

@@ -104,8 +104,7 @@ void DrawLooperBuilder::addShadow(const FloatSize& offset, float blur, const Col

paint->setMaskFilter(mf.get());

}

- RefPtr<SkColorFilter> cf = adoptRef(SkColorFilter::CreateModeFilter(skColor, SkXfermode::kSrcIn_Mode));

- paint->setColorFilter(cf.get());

+ paint->setColorFilter(SkColorFilter::MakeModeFilter(skColor, SkXfermode::kSrcIn_Mode));

}

} // namespace blink