third_party/WebKit/Source/platform/graphics/GraphicsContextState.cpp - Issue 1829093002: Use sk_sp-based APIs for SkColorFilter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/GraphicsContextState.cpp

Issue 1829093002: Use sk_sp-based APIs for SkColorFilter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Respond to reviews Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/GraphicsContextState.h ('k') | third_party/WebKit/Source/platform/graphics/filters/FEColorMatrix.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/GraphicsContextState.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/GraphicsContextState.cpp b/third_party/WebKit/Source/platform/graphics/GraphicsContextState.cpp

index 4db36e0669fb1abb4f15f38d44a536775735ece4..7725a54240b67090ef84f8443aa0bc8328843e27 100644

--- a/third_party/WebKit/Source/platform/graphics/GraphicsContextState.cpp

+++ b/third_party/WebKit/Source/platform/graphics/GraphicsContextState.cpp

@@ -157,9 +157,9 @@ void GraphicsContextState::setLineDash(const DashArray& dashes, float dashOffset

void GraphicsContextState::setColorFilter(PassRefPtr<SkColorFilter> colorFilter)

{

- m_colorFilter = colorFilter;

- m_strokePaint.setColorFilter(m_colorFilter.get());

- m_fillPaint.setColorFilter(m_colorFilter.get());

+ m_colorFilter = toSkSp(colorFilter);

f(malita) 2016/03/28 13:39:32 Hmm, looking at this code I wonder why we need m_c

+ m_strokePaint.setColorFilter(m_colorFilter);

+ m_fillPaint.setColorFilter(m_colorFilter);

}

void GraphicsContextState::setInterpolationQuality(InterpolationQuality quality)