Issue 182843002: Drop isindex from HTMLTagNames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 182843002: Drop isindex from HTMLTagNames. (Closed)

Created:
6 years, 9 months ago by Mike West

Modified:
6 years, 9 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Drop isindex from HTMLTagNames. Followup from https://codereview.chromium.org/96653004/ This requires an update to the generation scripts, as they must treat the fallback interface as an interface supporting multiple tag names. This only accidentally worked, as both 'image' and 'isindex' were listed as using the HTMLUnknownElement interface. Removing 'isindex' exposed the bug. "Intent to Remove" discussion: https://groups.google.com/a/chromium.org/d/msg/blink-dev/14q_I06gwg8/0a3JI0kjbC0J Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168033

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -3 lines)			Patch
M	Source/build/scripts/make_element_factory.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/build/scripts/make_element_type_helpers.py	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/core/html/HTMLTagNames.in	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

Mike West

WDYT, Jochen? I split this out into a separate CL, as it wasn't quite clear ...

6 years, 9 months ago (2014-02-27 08:51:29 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/182843002/1

6 years, 9 months ago (2014-02-27 14:25:09 UTC) #4

Message was sent while issue was closed.

Change committed as 168033