Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 96653004: Remove support for the obsolete <isindex> tag. (Closed)

Created:
6 years ago by Mike West
Modified:
5 years, 9 months ago
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Visibility:
Public.

Description

Remove support for the obsolete <isindex> tag. This patch removes all special-casing for the <isindex> tag; it now behaves exactly like <foo> in all respects. This additionally means that we can remove the special-casing for forms containing <input name="isindex"> as their first element. The various tests for <isindex> have been deleted, with the exception of the imported HTML5Lib tests. It's not clear that we should send them patches to remove the <isindex> tests, at least not while the element is (an obsolete) part of HTML5, and supported by other vendors. I've just landed failing test results here. That seems like the right thing to do. "Intent to Remove" discussion: https://groups.google.com/a/chromium.org/d/msg/blink-dev/14q_I06gwg8/0a3JI0kjbC0J Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168010

Patch Set 1 #

Patch Set 2 : Test. #

Patch Set 3 : Test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+462 lines, -777 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
D LayoutTests/dom/html/level2/html/HTMLIsIndexElement01.html View 1 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/dom/html/level2/html/HTMLIsIndexElement01.js View 1 1 chunk +0 lines, -122 lines 0 comments Download
D LayoutTests/dom/html/level2/html/HTMLIsIndexElement01-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/dom/html/level2/html/HTMLIsIndexElement02.html View 1 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/dom/html/level2/html/HTMLIsIndexElement02.js View 1 1 chunk +0 lines, -119 lines 0 comments Download
D LayoutTests/dom/html/level2/html/HTMLIsIndexElement02-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/dom/html/level2/html/HTMLIsIndexElement03.html View 1 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/dom/html/level2/html/HTMLIsIndexElement03.js View 1 1 chunk +0 lines, -114 lines 0 comments Download
D LayoutTests/dom/html/level2/html/HTMLIsIndexElement03-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/HTMLElement/ie-forbids-insert-html.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/HTMLElement/ie-forbids-insert-html-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/fast/dom/isindex-001.html View 1 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/dom/isindex-002.html View 1 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/events/resources/tabindex-focus-blur-all.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/events/resources/tabindex-focus-blur-all-frame1.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/events/resources/tabindex-focus-blur-all-frame2.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/events/resources/tabindex-focus-blur-all-iframe1.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/events/resources/tabindex-focus-blur-all-iframe2.html View 1 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/forms/isindex-name.html View 1 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/fast/forms/isindex-name-expected.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/forms/isindex-placeholder.html View 1 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/fast/forms/isindex-placeholder-expected.html View 1 1 chunk +0 lines, -11 lines 0 comments Download
M LayoutTests/fast/forms/text-style-color.html View 1 1 chunk +0 lines, -9 lines 0 comments Download
M LayoutTests/fast/parser/fragment-parser-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/parser/script-tests/fragment-parser.js View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/replaced/table-percent-height-text-controls.html View 1 2 chunks +0 lines, -7 lines 0 comments Download
M LayoutTests/html5lib/generated/run-isindex-data-expected.txt View 1 1 chunk +62 lines, -1 line 0 comments Download
M LayoutTests/html5lib/generated/run-isindex-write-expected.txt View 1 1 chunk +62 lines, -1 line 0 comments Download
M LayoutTests/html5lib/generated/run-tests19-data-expected.txt View 1 1 chunk +112 lines, -1 line 0 comments Download
M LayoutTests/html5lib/generated/run-tests19-write-expected.txt View 1 1 chunk +112 lines, -1 line 0 comments Download
M LayoutTests/html5lib/generated/run-tests2-data-expected.txt View 1 1 chunk +24 lines, -1 line 0 comments Download
M LayoutTests/html5lib/generated/run-tests2-write-expected.txt View 1 1 chunk +24 lines, -1 line 0 comments Download
M LayoutTests/html5lib/generated/run-webkit02-data-expected.txt View 1 1 chunk +17 lines, -1 line 0 comments Download
M LayoutTests/html5lib/generated/run-webkit02-write-expected.txt View 1 1 chunk +17 lines, -1 line 0 comments Download
D LayoutTests/http/tests/misc/isindex-formdata.html View 1 1 chunk +0 lines, -42 lines 0 comments Download
D LayoutTests/http/tests/misc/isindex-formdata-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/http/tests/misc/isindex-with-no-form.html View 1 1 chunk +0 lines, -44 lines 0 comments Download
D LayoutTests/http/tests/misc/isindex-with-no-form-base-href.html View 1 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/http/tests/misc/isindex-with-no-form-base-href-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/http/tests/misc/isindex-with-no-form-expected.txt View 1 1 chunk +0 lines, -7 lines 0 comments Download
M LayoutTests/platform/mac/fast/replaced/table-percent-height-text-controls-expected.txt View 1 2 2 chunks +0 lines, -5 lines 0 comments Download
M LayoutTests/platform/win/fast/forms/text-style-color-expected.txt View 1 1 chunk +15 lines, -76 lines 0 comments Download
M LayoutTests/platform/win/fast/replaced/table-percent-height-text-controls-expected.txt View 1 2 chunks +0 lines, -5 lines 0 comments Download
M Source/core/css/html.css View 1 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/css/themeChromium.css View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/FormDataList.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M Source/core/html/HTMLElement.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/parser/HTMLStackItem.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/parser/HTMLTreeBuilder.cpp View 1 2 chunks +0 lines, -47 lines 0 comments Download
M Source/devtools/front_end/ElementsTreeOutline.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebSearchableFormData.cpp View 1 1 chunk +4 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Mike West
Hi Eric, Dimitri, and Jochen! WDYT (particularly about the failing HTML5Lib tests)? -mike
5 years, 9 months ago (2014-02-26 10:55:40 UTC) #1
eseidel
lgtm
5 years, 9 months ago (2014-02-26 18:58:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/96653004/70001
5 years, 9 months ago (2014-02-26 18:58:43 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
5 years, 9 months ago (2014-02-26 21:45:51 UTC) #4
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_rel&number=20153
5 years, 9 months ago (2014-02-26 21:45:51 UTC) #5
Mike West
The CQ bit was checked by mkwst@chromium.org
5 years, 9 months ago (2014-02-27 08:17:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/96653004/90001
5 years, 9 months ago (2014-02-27 08:17:26 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2014-02-27 10:32:55 UTC) #8
Message was sent while issue was closed.
Change committed as 168010

Powered by Google App Engine
This is Rietveld 408576698