Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: Source/build/scripts/make_element_type_helpers.py

Issue 182843002: Drop isindex from HTMLTagNames. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/build/scripts/make_element_factory.py ('k') | Source/core/html/HTMLTagNames.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/build/scripts/make_element_type_helpers.py
diff --git a/Source/build/scripts/make_element_type_helpers.py b/Source/build/scripts/make_element_type_helpers.py
index ff5c4491e381031f3c534f356f47f6343e6ff2f5..b67d15abf2c165aaf72a5453d96259bcab5f104f 100755
--- a/Source/build/scripts/make_element_type_helpers.py
+++ b/Source/build/scripts/make_element_type_helpers.py
@@ -42,6 +42,7 @@ class MakeElementTypeHelpersWriter(in_generator.Writer):
super(MakeElementTypeHelpersWriter, self).__init__(in_file_path)
self.namespace = self.in_file.parameters['namespace'].strip('"')
+ self.fallbackInterface = self.in_file.parameters['fallbackInterfaceName'].strip('"')
assert self.namespace, 'A namespace is required.'
@@ -61,7 +62,7 @@ class MakeElementTypeHelpersWriter(in_generator.Writer):
interface_counts[tag['interface']] += 1
for tag in tags:
- tag['multipleTagNames'] = interface_counts[tag['interface']] > 1
+ tag['multipleTagNames'] = (interface_counts[tag['interface']] > 1 or tag['interface'] == self.fallbackInterface)
@template_expander.use_jinja("ElementTypeHelpers.h.tmpl", filters=filters)
def generate_helper_header(self):
« no previous file with comments | « Source/build/scripts/make_element_factory.py ('k') | Source/core/html/HTMLTagNames.in » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698