Web shell integration test suite.

Web shell integration test suite.

Integration test suite for the web shell, based on EarlGrey. This
includes the suite and gyp configurations to build and run two
sample tests.

build/common.gypi change is a revert of
https://codereview.chromium.org/1538973002, TBRed

BUG=583736
TBR=dpranke@chromium.org

Committed: https://crrev.com/fe083b305a95370de0877e17aec60fabebacbb96
Cr-Commit-Position: refs/heads/master@{#383414}

[justincohen, 2016-03-25 18:08:54]

justincohen@chromium.org changed reviewers:
+ baxley@chromium.org, sdefresne@chromium.org

[justincohen, 2016-03-25 18:08:55]

stolen from baxley and modified a bit.

[baxley, 2016-03-25 18:33:32]

lgtm

[justincohen, 2016-03-25 18:42:02]

Description was changed from

==========
Web shell integration test suite.

Integration test suite for the web shell, based on EarlGrey. This
includes the suite and gyp configurations to build and run two
sample tests.

Change from Baxley's CL, fix release builds.

BUG=583736

patch from issue 1804163006 at patchset 120001
(http://crrev.com/1804163006#ps120001)
==========

to

==========
Web shell integration test suite.

Integration test suite for the web shell, based on EarlGrey. This
includes the suite and gyp configurations to build and run two
sample tests.

build/common.gypi change is a revert of 
https://codereview.chromium.org/1538973002, TBRed

BUG=583736
TBR=dpranke
==========

[justincohen, 2016-03-25 18:42:26]

Description was changed from

==========
Web shell integration test suite.

Integration test suite for the web shell, based on EarlGrey. This
includes the suite and gyp configurations to build and run two
sample tests.

build/common.gypi change is a revert of 
https://codereview.chromium.org/1538973002, TBRed

BUG=583736
TBR=dpranke
==========

to

==========
Web shell integration test suite.

Integration test suite for the web shell, based on EarlGrey. This
includes the suite and gyp configurations to build and run two
sample tests.

build/common.gypi change is a revert of 
https://codereview.chromium.org/1538973002, TBRed

BUG=583736
TBR=dpranke@chromium.org
==========

[justincohen, 2016-03-25 18:44:47]

The CQ bit was checked by justincohen@chromium.org

[justincohen, 2016-03-25 18:44:58]

The CQ bit was unchecked by justincohen@chromium.org

[justincohen, 2016-03-25 20:35:22]

Patchset #3 (id:40001) has been deleted

[sdefresne, 2016-03-25 21:26:17]

https://codereview.chromium.org/1828143007/diff/20001/ios/third_party/ochamcr...
File ios/third_party/ochamcrest/ochamcrest.gyp (right):

https://codereview.chromium.org/1828143007/diff/20001/ios/third_party/ochamcr...
ios/third_party/ochamcrest/ochamcrest.gyp:236:
'$(SDKROOT)/../../Library/Frameworks',
nit: maybe comment why this is added to mac_framework_dirs? Is this also for
XCTests.Framework? It is not in link_settings, so I do not know why this is
here? Can it be removed?

https://codereview.chromium.org/1828143007/diff/20001/ios/web/ios_web_shell.gyp
File ios/web/ios_web_shell.gyp (right):

https://codereview.chromium.org/1828143007/diff/20001/ios/web/ios_web_shell.g...
ios/web/ios_web_shell.gyp:25: '-Xlinker -objc_abi_version -Xlinker 2
-exported_symbols_list',
nit: can this be set as

'OTHER_LDFLAGS': [
  '-Xlinker -objc_abi_version',
  '-Xlinker 2',
  '-exported_symbols_list',
  '../../ios/web/ios_web_shell_exported_symbols_list'
]

https://codereview.chromium.org/1828143007/diff/20001/ios/web/ios_web_shell.g...
ios/web/ios_web_shell.gyp:26:
'../../ios/web/ios_web_shell_exported_symbols_list'
Is this file an input? I should be marked as so, so that the build is rerun if
the file is updated.

https://codereview.chromium.org/1828143007/diff/20001/ios/web/ios_web_shell.g...
ios/web/ios_web_shell.gyp:74: 'GCC_SYMBOLS_PRIVATE_EXTERN': 'NO',
Please comment.

https://codereview.chromium.org/1828143007/diff/20001/ios/web/ios_web_shell_t...
File ios/web/ios_web_shell_tests.gyp (right):

https://codereview.chromium.org/1828143007/diff/20001/ios/web/ios_web_shell_t...
ios/web/ios_web_shell_tests.gyp:16: 'test_host':
'${BUILT_PRODUCTS_DIR}/ios_web_shell.app/ios_web_shell',
I think this should be "$(BUILD_PRODUCTS_DIR)" since Xcode prefers to use $()
than ${} for variable substitutions (both works I think but the former is how
Xcode formats all its variables)..

[sdefresne, 2016-03-25 21:26:45]

lgtm to unblock you, but please address comments

[sdefresne, 2016-03-25 22:27:10]

lgtm

https://codereview.chromium.org/1828143007/diff/60001/ios/web/ios_web_shell_t...
File ios/web/ios_web_shell_tests.gyp (right):

https://codereview.chromium.org/1828143007/diff/60001/ios/web/ios_web_shell_t...
ios/web/ios_web_shell_tests.gyp:52: 'targets': [
As a followup:

'targets': [
  {
    # The iOS frameworks being built for ios_web_shell_test require certs which
    # bot do not currently have installed.  Ninja allows this, Xcode does not.
    'target_name': 'ios_web_shell_test',
    'type': 'none',
  },
],

Or remove the else block.

[justincohen, 2016-03-25 22:27:54]

The CQ bit was checked by justincohen@chromium.org

[justincohen, 2016-03-25 22:27:54]

The patchset sent to the CQ was uploaded after l-g-t-m from baxley@chromium.org
Link to the patchset: https://codereview.chromium.org/1828143007/#ps60001
(title: "Turn off ios_web_shell_test for Xcode")

[commit-bot: I haz the power, 2016-03-25 22:28:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1828143007/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1828143007/60001

[justincohen, 2016-03-25 22:45:43]

The CQ bit was unchecked by justincohen@chromium.org

[justincohen, 2016-03-25 22:50:59]

The CQ bit was checked by justincohen@chromium.org

[justincohen, 2016-03-25 22:51:00]

The patchset sent to the CQ was uploaded after l-g-t-m from baxley@chromium.org,
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/1828143007/#ps80001
(title: "Wrong GENERATOR plus some of Sylvain comments, but not all")

[commit-bot: I haz the power, 2016-03-25 22:51:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1828143007/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1828143007/80001

[justincohen, 2016-03-25 22:51:21]

Addressed some of the comments, not all.  Save that for a followup.

https://codereview.chromium.org/1828143007/diff/20001/ios/web/ios_web_shell.gyp
File ios/web/ios_web_shell.gyp (right):

https://codereview.chromium.org/1828143007/diff/20001/ios/web/ios_web_shell.g...
ios/web/ios_web_shell.gyp:25: '-Xlinker -objc_abi_version -Xlinker 2
-exported_symbols_list',
On 2016/03/25 21:26:16, sdefresne (OOO till 4th April) wrote:
> nit: can this be set as
> 
> 'OTHER_LDFLAGS': [
>   '-Xlinker -objc_abi_version',
>   '-Xlinker 2',
>   '-exported_symbols_list',
>   '../../ios/web/ios_web_shell_exported_symbols_list'
> ]

Done.

https://codereview.chromium.org/1828143007/diff/60001/ios/web/ios_web_shell_t...
File ios/web/ios_web_shell_tests.gyp (right):

https://codereview.chromium.org/1828143007/diff/60001/ios/web/ios_web_shell_t...
ios/web/ios_web_shell_tests.gyp:52: 'targets': [
On 2016/03/25 22:27:10, sdefresne (OOO till 4th April) wrote:
> As a followup:
> 
> 'targets': [
>   {
>     # The iOS frameworks being built for ios_web_shell_test require certs
which
>     # bot do not currently have installed.  Ninja allows this, Xcode does not.
>     'target_name': 'ios_web_shell_test',
>     'type': 'none',
>   },
> ],
> 
> Or remove the else block.

Done.

[justincohen, 2016-03-25 22:53:38]

https://codereview.chromium.org/1828143007/diff/20001/ios/web/ios_web_shell_t...
File ios/web/ios_web_shell_tests.gyp (right):

https://codereview.chromium.org/1828143007/diff/20001/ios/web/ios_web_shell_t...
ios/web/ios_web_shell_tests.gyp:16: 'test_host':
'${BUILT_PRODUCTS_DIR}/ios_web_shell.app/ios_web_shell',
On 2016/03/25 21:26:16, sdefresne (OOO till 4th April) wrote:
> I think this should be "$(BUILD_PRODUCTS_DIR)" since Xcode prefers to use $()
> than ${} for variable substitutions (both works I think but the former is how
> Xcode formats all its variables)..

I already removed this.

[commit-bot: I haz the power, 2016-03-26 00:03:19]

Description was changed from

==========
Web shell integration test suite.

Integration test suite for the web shell, based on EarlGrey. This
includes the suite and gyp configurations to build and run two
sample tests.

build/common.gypi change is a revert of 
https://codereview.chromium.org/1538973002, TBRed

BUG=583736
TBR=dpranke@chromium.org
==========

to

==========
Web shell integration test suite.

Integration test suite for the web shell, based on EarlGrey. This
includes the suite and gyp configurations to build and run two
sample tests.

build/common.gypi change is a revert of 
https://codereview.chromium.org/1538973002, TBRed

BUG=583736
TBR=dpranke@chromium.org
==========

[commit-bot: I haz the power, 2016-03-26 00:03:20]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-03-26 00:05:30]

Description was changed from

==========
Web shell integration test suite.

Integration test suite for the web shell, based on EarlGrey. This
includes the suite and gyp configurations to build and run two
sample tests.

build/common.gypi change is a revert of 
https://codereview.chromium.org/1538973002, TBRed

BUG=583736
TBR=dpranke@chromium.org
==========

to

==========
Web shell integration test suite.

Integration test suite for the web shell, based on EarlGrey. This
includes the suite and gyp configurations to build and run two
sample tests.

build/common.gypi change is a revert of
https://codereview.chromium.org/1538973002, TBRed

BUG=583736
TBR=dpranke@chromium.org

Committed: https://crrev.com/fe083b305a95370de0877e17aec60fabebacbb96
Cr-Commit-Position: refs/heads/master@{#383414}
==========

[commit-bot: I haz the power, 2016-03-26 00:05:32]

Patchset 4 (id:??) landed as
https://crrev.com/fe083b305a95370de0877e17aec60fabebacbb96
Cr-Commit-Position: refs/heads/master@{#383414}