Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 # Copyright 2014 The Chromium Authors. All rights reserved. | 1 # Copyright 2014 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 { | 5 { |
| 6 'variables': { | 6 'variables': { |
| 7 'chromium_code': 1, | 7 'chromium_code': 1, |
| 8 }, | 8 }, |
| 9 'targets': [ | 9 'targets': [ |
| 10 { | 10 { |
| 11 # GN version: //ios/web/shell:ios_web_shell | 11 # GN version: //ios/web/shell:ios_web_shell |
| 12 'target_name': 'ios_web_shell', | 12 'target_name': 'ios_web_shell', |
| 13 'type': 'executable', | 13 'type': 'executable', |
| 14 'mac_bundle': 1, | 14 'mac_bundle': 1, |
| 15 'include_dirs': [ | 15 'include_dirs': [ |
| 16 '../..', | 16 '../..', |
| 17 ], | 17 ], |
| 18 'dependencies': [ | 18 'dependencies': [ |
| 19 'ios_web_shell_lib', | 19 'ios_web_shell_lib', |
| 20 ], | 20 ], |
| 21 'xcode_settings': { | 21 'xcode_settings': { |
| 22 'INFOPLIST_FILE': 'shell/Info.plist', | 22 'INFOPLIST_FILE': 'shell/Info.plist', |
| 23 'STRIPFLAGS': '-S', | |
| 23 'OTHER_LDFLAGS': [ | 24 'OTHER_LDFLAGS': [ |
| 24 '-Xlinker -objc_abi_version -Xlinker 2' | 25 '-Xlinker -objc_abi_version -Xlinker 2 -exported_symbols_list', |
|
sdefresne
2016/03/25 21:26:16
nit: can this be set as
'OTHER_LDFLAGS': [
'-Xl
justincohen
2016/03/25 22:51:21
Done.
| |
| 26 '../../ios/web/ios_web_shell_exported_symbols_list' | |
|
sdefresne
2016/03/25 21:26:16
Is this file an input? I should be marked as so, s
| |
| 25 ] | 27 ] |
| 26 }, | 28 }, |
| 27 'sources': [ | 29 'sources': [ |
| 28 'shell/web_exe_main.mm', | 30 'shell/web_exe_main.mm', |
| 29 ], | 31 ], |
| 30 }, | 32 }, |
| 31 { | 33 { |
| 32 # GN version: //ios/web/shell:shell | 34 # GN version: //ios/web/shell:shell |
| 33 'target_name': 'ios_web_shell_lib', | 35 'target_name': 'ios_web_shell_lib', |
| 34 'type': 'static_library', | 36 'type': 'static_library', |
| (...skipping 26 matching lines...) Expand all Loading... | |
| 61 'shell/shell_network_delegate.h', | 63 'shell/shell_network_delegate.h', |
| 62 'shell/shell_url_request_context_getter.h', | 64 'shell/shell_url_request_context_getter.h', |
| 63 'shell/shell_url_request_context_getter.mm', | 65 'shell/shell_url_request_context_getter.mm', |
| 64 'shell/shell_web_client.h', | 66 'shell/shell_web_client.h', |
| 65 'shell/shell_web_client.mm', | 67 'shell/shell_web_client.mm', |
| 66 'shell/shell_web_main_parts.h', | 68 'shell/shell_web_main_parts.h', |
| 67 'shell/shell_web_main_parts.mm', | 69 'shell/shell_web_main_parts.mm', |
| 68 'shell/view_controller.h', | 70 'shell/view_controller.h', |
| 69 'shell/view_controller.mm', | 71 'shell/view_controller.mm', |
| 70 ], | 72 ], |
| 73 'xcode_settings': { | |
| 74 'GCC_SYMBOLS_PRIVATE_EXTERN': 'NO', | |
|
sdefresne
2016/03/25 21:26:16
Please comment.
| |
| 75 }, | |
| 71 'link_settings': { | 76 'link_settings': { |
| 72 'libraries': [ | 77 'libraries': [ |
| 73 '$(SDKROOT)/System/Library/Frameworks/CoreGraphics.framework', | 78 '$(SDKROOT)/System/Library/Frameworks/CoreGraphics.framework', |
| 74 '$(SDKROOT)/System/Library/Frameworks/CoreFoundation.framework', | 79 '$(SDKROOT)/System/Library/Frameworks/CoreFoundation.framework', |
| 75 '$(SDKROOT)/System/Library/Frameworks/Foundation.framework', | 80 '$(SDKROOT)/System/Library/Frameworks/Foundation.framework', |
| 76 '$(SDKROOT)/System/Library/Frameworks/UIKit.framework', | 81 '$(SDKROOT)/System/Library/Frameworks/UIKit.framework', |
| 77 ], | 82 ], |
| 78 'mac_bundle_resources': [ | 83 'mac_bundle_resources': [ |
| 79 'shell/Default.png', | 84 'shell/Default.png', |
| 80 'shell/MainView.xib', | 85 'shell/MainView.xib', |
| 81 'shell/textfield_background@2x.png', | 86 'shell/textfield_background@2x.png', |
| 82 'shell/toolbar_back@2x.png', | 87 'shell/toolbar_back@2x.png', |
| 83 'shell/toolbar_forward@2x.png', | 88 'shell/toolbar_forward@2x.png', |
| 84 ], | 89 ], |
| 85 }, | 90 }, |
| 86 }, | 91 }, |
| 87 ], | 92 ], |
| 88 } | 93 } |
| OLD | NEW |