Reland Don't set -fvisibility=hidden for iOS Debug in GYP.

Reland Don't set -fvisibility=hidden for iOS Debug in GYP.

Remove -fvisibility=hidden for Debug configuration on iOS at the
top level (common.gypi), so we don't remove symbols from
dependencies.

BUG=569073
Committed: https://crrev.com/9937fc8c7219feff1d0c8bb2fe4817d0c84aa93b
Cr-Commit-Position: refs/heads/master@{#368133}

[baxley, 2015-12-18 22:50:51]

baxley@chromium.org changed reviewers:
+ dpranke@google.com

[baxley, 2015-12-18 22:50:52]

This is a reland of https://codereview.chromium.org/1533003002/

Patch 1 is the original CL that landed and was reverted.
Patch 3 has the latest changes.

The cleanest diff is probably against origin. I had a 'configuration' within
'xcode_settings' which had some problems when building for xcode build with
device. I verified the latest patch with a couple of different xcode + ninja
builds.

[Dirk Pranke, 2015-12-19 19:54:09]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2015-12-19 19:54:09]

lgtm

[baxley, 2016-01-04 19:42:31]

PTAL. I modified the CL to keep the old behavior on mac. This will keep the
Debug binary size from growing, since mac doesn't seem to need to not use
fvisibiliity=hidden. Thanks!

[sdefresne, 2016-01-06 16:52:10]

sdefresne@chromium.org changed reviewers:
+ sdefresne@chromium.org

[sdefresne, 2016-01-06 16:52:11]

lgtm

[baxley, 2016-01-06 16:58:18]

The CQ bit was checked by baxley@chromium.org

[baxley, 2016-01-06 16:58:18]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1538973002/#ps80001
(title: "keep old behavior for mac")

[commit-bot: I haz the power, 2016-01-06 16:58:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1538973002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1538973002/80001

[commit-bot: I haz the power, 2016-01-06 17:03:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-06 17:03:06]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[baxley, 2016-01-06 19:41:03]

Sylvain, could you PTAL?

There was an error on linux_android... where having the same key name
('conditions') at the same level wouldn't work with gyp. I moved the changes
into the second 'conditions' block and the try jobs passed.

[sdefresne, 2016-01-07 16:50:21]

https://codereview.chromium.org/1538973002/diff/100001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/1538973002/diff/100001/build/common.gypi#newc...
build/common.gypi:5148: ],
I think you should put your code here.

[baxley, 2016-01-07 16:57:48]

On 2016/01/07 16:50:21, sdefresne wrote:
> https://codereview.chromium.org/1538973002/diff/100001/build/common.gypi
> File build/common.gypi (right):
> 
>
https://codereview.chromium.org/1538973002/diff/100001/build/common.gypi#newc...
> build/common.gypi:5148: ],
> I think you should put your code here.

I agree that it makes more sense there, that was how I had the original CL that
I reverted. It failed on xcodebuild, and it looked to not like having
'configurations' under an xcode_settings block. If that is true, it should be a
bug. I'll go ahead and see if I can reproduce the problem with a simple test.

[sdefresne, 2016-01-07 17:51:29]

It's strange. LGTM if the bots pass then.

[baxley, 2016-01-07 18:47:11]

The CQ bit was checked by baxley@chromium.org

[baxley, 2016-01-07 18:47:11]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1538973002/#ps100001
(title: "combine conditions sections")

[commit-bot: I haz the power, 2016-01-07 18:47:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1538973002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1538973002/100001

[commit-bot: I haz the power, 2016-01-07 19:55:11]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-01-07 19:56:03]

Description was changed from

==========
Reland Don't set -fvisibility=hidden for iOS Debug in GYP.

Remove -fvisibility=hidden for Debug configuration on iOS at the
top level (common.gypi), so we don't remove symbols from
dependencies.

BUG=569073
==========

to

==========
Reland Don't set -fvisibility=hidden for iOS Debug in GYP.

Remove -fvisibility=hidden for Debug configuration on iOS at the
top level (common.gypi), so we don't remove symbols from
dependencies.

BUG=569073

Committed: https://crrev.com/9937fc8c7219feff1d0c8bb2fe4817d0c84aa93b
Cr-Commit-Position: refs/heads/master@{#368133}
==========

[commit-bot: I haz the power, 2016-01-07 19:56:04]

Patchset 6 (id:??) landed as
https://crrev.com/9937fc8c7219feff1d0c8bb2fe4817d0c84aa93b
Cr-Commit-Position: refs/heads/master@{#368133}