ios/web/ios_web_shell.gyp - Issue 1828143007: Web shell integration test suite.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/ios_web_shell.gyp

Issue 1828143007: Web shell integration test suite. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Wrong GENERATOR plus some of Sylvain comments, but not all Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/ios_web_shell.gyp

diff --git a/ios/web/ios_web_shell.gyp b/ios/web/ios_web_shell.gyp

index 9659780e3daf149931d775e6a95ca1d9b09f7ddf..e4a5c649fe6c2cfe5818b74ac9825d772affd4d5 100644

--- a/ios/web/ios_web_shell.gyp

+++ b/ios/web/ios_web_shell.gyp

@@ -20,8 +20,12 @@

'xcode_settings': {

'INFOPLIST_FILE': 'shell/Info.plist',

+ 'STRIPFLAGS': '-S',

'OTHER_LDFLAGS': [

- '-Xlinker -objc_abi_version -Xlinker 2'

+ '-Xlinker -objc_abi_version',

+ '-Xlinker 2',

+ '-exported_symbols_list',

+ '../../ios/web/ios_web_shell_exported_symbols_list'

]

'sources': [

@@ -68,6 +72,9 @@

'shell/view_controller.h',

'shell/view_controller.mm',

+ 'xcode_settings': {

+ 'GCC_SYMBOLS_PRIVATE_EXTERN': 'NO',

+ },

'link_settings': {

'libraries': [

'$(SDKROOT)/System/Library/Frameworks/CoreGraphics.framework',

« no previous file with comments | « ios/web/DEPS ('k') | ios/web/ios_web_shell_exported_symbols_list » ('j') | no next file with comments »