Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1826283004: Revert NotImplemented() changes in r383029 and r383047. (Closed)

Created:
4 years, 9 months ago by Dirk Pranke
Modified:
4 years, 9 months ago
Reviewers:
tkent
CC:
ajuma+watch-canvas_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-events_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-reviews-style_chromium.org, blink-reviews-wtf_chromium.org, blink-worker-reviews_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dcheng, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, dtapuska+blinkwatch_chromium.org, eae+blinkwatch, falken, f(malita), horo+watch_chromium.org, jbroman, jchaffraix+rendering, jsbell+serviceworker_chromium.org, Justin Novosad, kinuko+serviceworker, kinuko+watch, kinuko+worker_chromium.org, leviw+renderwatch, michaeln, Mikhail, mlamouri+watch-blink_chromium.org, nhiroki, pdr+renderingwatchlist_chromium.org, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, serviceworker-reviews, sof, szager+layoutwatch_chromium.org, tzik, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert NotImplemented() changes in r383029 and r383047. These changes are causing NotImplemented() messages to get logged all over the place which, among other things, is bringing the buildbots to their knees. TBR=tkent@chromium.org BUG=596760 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://chromium.googlesource.com/chromium/src/+/0e32be016d4311438b3d1329b969c4ae6ac48721

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -89 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/clipboard/DataTransfer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 2 chunks +2 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Position.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTokenizer.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp View 6 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutRubyBase.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/TableLayoutAlgorithmAuto.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/ContextMenuController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/CoreTestPrinters.cpp View 3 chunks +41 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerObjectProxy.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediacapturefromelement/CanvasCaptureMediaStreamTrack.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediacapturefromelement/HTMLMediaElementCapture.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 5 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/Logging.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/Logging.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/platform/NotImplemented.h View 2 chunks +19 lines, -13 lines 0 comments Download
A + third_party/WebKit/Source/platform/NotImplemented.cpp View 2 chunks +9 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/PlatformKeyboardEvent.cpp View 3 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/mac/FontPlatformDataMac.mm View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/text/TextBreakIteratorICU.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/text/UnicodeUtilities.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/Assertions.h View 3 chunks +23 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/Assertions.cpp View 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0e32be016d4311438b3d1329b969c4ae6ac48721 Cr-Commit-Position: refs/heads/master@{#383149}
4 years, 9 months ago (2016-03-24 21:22:18 UTC) #3
Dirk Pranke
Committed patchset #1 (id:1) manually as 0e32be016d4311438b3d1329b969c4ae6ac48721 (presubmit successful).
4 years, 9 months ago (2016-03-24 21:22:57 UTC) #5
tkent
4 years, 9 months ago (2016-03-24 23:15:59 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698