Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Unified Diff: third_party/WebKit/Source/platform/NotImplemented.h

Issue 1826283004: Revert NotImplemented() changes in r383029 and r383047. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/NotImplemented.h
diff --git a/third_party/WebKit/Source/platform/weborigin/KnownPorts.h b/third_party/WebKit/Source/platform/NotImplemented.h
similarity index 69%
copy from third_party/WebKit/Source/platform/weborigin/KnownPorts.h
copy to third_party/WebKit/Source/platform/NotImplemented.h
index c347a2fe6bd665d23f283979cac6a548c766ff0e..f9009ec2f7f577dc98f0d9e60221a515ef804378 100644
--- a/third_party/WebKit/Source/platform/weborigin/KnownPorts.h
+++ b/third_party/WebKit/Source/platform/NotImplemented.h
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2011, 2012 Apple Inc. All rights reserved.
+ * Copyright (C) 2007 Apple Computer, Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -23,22 +23,28 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef KnownPorts_h
-#define KnownPorts_h
+#ifndef NotImplemented_h
+#define NotImplemented_h
#include "platform/PlatformExport.h"
-#include "wtf/text/WTFString.h"
+#include "wtf/Assertions.h"
-namespace blink {
-
-class KURL;
+#if LOG_DISABLED
+ #define notImplemented() ((void)0)
+#else
-// Returns true if |port| is known to be the default for |protocol|. |protocol| must be lower case.
-PLATFORM_EXPORT bool isDefaultPortForProtocol(unsigned short port, const WTF::String& protocol);
+namespace blink {
+PLATFORM_EXPORT WTFLogChannel* notImplementedLoggingChannel();
+} // namespace blink
-// Returns 0 for unknown protocols. |protocol| must be lower case.
-PLATFORM_EXPORT unsigned short defaultPortForProtocol(const WTF::String& protocol);
+#define notImplemented() do { \
+ static bool havePrinted = false; \
+ if (!havePrinted) { \
+ WTFLogVerbose(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, blink::notImplementedLoggingChannel(), "UNIMPLEMENTED: "); \
+ havePrinted = true; \
+ } \
+ } while (0)
-} // namespace blink
+#endif // NDEBUG
-#endif // KnownPorts_h
+#endif // NotImplemented_h
« no previous file with comments | « third_party/WebKit/Source/platform/Logging.cpp ('k') | third_party/WebKit/Source/platform/NotImplemented.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698