Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp

Issue 1826283004: Revert NotImplemented() changes in r383029 and r383047. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/serviceworkers/WaitUntilObserver.h" 5 #include "modules/serviceworkers/WaitUntilObserver.h"
6 6
7 #include "bindings/core/v8/ScriptFunction.h" 7 #include "bindings/core/v8/ScriptFunction.h"
8 #include "bindings/core/v8/ScriptPromise.h" 8 #include "bindings/core/v8/ScriptPromise.h"
9 #include "bindings/core/v8/ScriptValue.h" 9 #include "bindings/core/v8/ScriptValue.h"
10 #include "bindings/core/v8/V8Binding.h" 10 #include "bindings/core/v8/V8Binding.h"
11 #include "core/dom/ExceptionCode.h" 11 #include "core/dom/ExceptionCode.h"
12 #include "core/dom/ExecutionContext.h" 12 #include "core/dom/ExecutionContext.h"
13 #include "modules/serviceworkers/ServiceWorkerGlobalScope.h" 13 #include "modules/serviceworkers/ServiceWorkerGlobalScope.h"
14 #include "platform/LayoutTestSupport.h" 14 #include "platform/LayoutTestSupport.h"
15 #include "platform/NotImplemented.h"
15 #include "public/platform/modules/serviceworker/WebServiceWorkerEventResult.h" 16 #include "public/platform/modules/serviceworker/WebServiceWorkerEventResult.h"
16 #include "wtf/Assertions.h" 17 #include "wtf/Assertions.h"
17 #include "wtf/RefCounted.h" 18 #include "wtf/RefCounted.h"
18 #include "wtf/RefPtr.h" 19 #include "wtf/RefPtr.h"
19 #include <v8.h> 20 #include <v8.h>
20 21
21 namespace blink { 22 namespace blink {
22 23
23 namespace { 24 namespace {
24 25
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 , m_pendingActivity(0) 137 , m_pendingActivity(0)
137 , m_hasError(false) 138 , m_hasError(false)
138 , m_eventDispatched(false) 139 , m_eventDispatched(false)
139 , m_consumeWindowInteractionTimer(this, &WaitUntilObserver::consumeWindowInt eraction) 140 , m_consumeWindowInteractionTimer(this, &WaitUntilObserver::consumeWindowInt eraction)
140 { 141 {
141 } 142 }
142 143
143 void WaitUntilObserver::reportError(const ScriptValue& value) 144 void WaitUntilObserver::reportError(const ScriptValue& value)
144 { 145 {
145 // FIXME: Propagate error message to the client for onerror handling. 146 // FIXME: Propagate error message to the client for onerror handling.
146 NOTIMPLEMENTED(); 147 notImplemented();
147 148
148 m_hasError = true; 149 m_hasError = true;
149 } 150 }
150 151
151 void WaitUntilObserver::incrementPendingActivity() 152 void WaitUntilObserver::incrementPendingActivity()
152 { 153 {
153 ++m_pendingActivity; 154 ++m_pendingActivity;
154 } 155 }
155 156
156 void WaitUntilObserver::decrementPendingActivity() 157 void WaitUntilObserver::decrementPendingActivity()
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
195 return; 196 return;
196 getExecutionContext()->consumeWindowInteraction(); 197 getExecutionContext()->consumeWindowInteraction();
197 } 198 }
198 199
199 DEFINE_TRACE(WaitUntilObserver) 200 DEFINE_TRACE(WaitUntilObserver)
200 { 201 {
201 ContextLifecycleObserver::trace(visitor); 202 ContextLifecycleObserver::trace(visitor);
202 } 203 }
203 204
204 } // namespace blink 205 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698