third_party/WebKit/Source/platform/text/TextBreakIteratorICU.cpp - Issue 1826283004: Revert NotImplemented() changes in r383029 and r383047.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/text/TextBreakIteratorICU.cpp

Issue 1826283004: Revert NotImplemented() changes in r383029 and r383047. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp ('k') | third_party/WebKit/Source/platform/text/UnicodeUtilities.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/text/TextBreakIteratorICU.cpp

diff --git a/third_party/WebKit/Source/platform/text/TextBreakIteratorICU.cpp b/third_party/WebKit/Source/platform/text/TextBreakIteratorICU.cpp

index 9691763b288d72ea081061fb9c23740dd4dbbef4..a00f757eda55baa93fdc1e529ea98f6ac409c4d0 100644

--- a/third_party/WebKit/Source/platform/text/TextBreakIteratorICU.cpp

+++ b/third_party/WebKit/Source/platform/text/TextBreakIteratorICU.cpp

@@ -82,7 +82,7 @@ public:

void put(icu::BreakIterator* iterator)

{

- DCHECK(m_vendedIterators.contains(iterator));

+ ASSERT_ARG(iterator, m_vendedIterators.contains(iterator));

if (m_pool.size() == capacity) {

delete(m_pool[0].second);

@@ -594,7 +594,8 @@ TextBreakIterator* acquireLineBreakIterator(const UChar* string, int length, con

void releaseLineBreakIterator(TextBreakIterator* iterator)

{

- DCHECK(iterator);

+ ASSERT_ARG(iterator, iterator);

LineBreakIteratorPool::sharedPool().put(iterator);

}