Move ScreenWin to ui/display

Move ScreenWin to ui/display

ScreenWin along with other Screen related objects is not really about graphics.
As a result, this goes to a new home called ui/display to hold things related to
the screen and display.

BUG=597105
Committed: https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c
Cr-Commit-Position: refs/heads/master@{#383500}

Committed: https://crrev.com/8d63729c779d6b529efb6d6a4c5985470c68f76b
Cr-Commit-Position: refs/heads/master@{#383761}

[robliao, 2016-03-23 01:00:19]

Patchset #1 (id:1) has been deleted

[robliao, 2016-03-23 01:00:25]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-23 01:00:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1825723002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1825723002/20001

[commit-bot: I haz the power, 2016-03-23 01:07:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-23 01:07:06]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oil...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[robliao, 2016-03-23 01:11:49]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-23 01:12:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1825723002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1825723002/40001

[commit-bot: I haz the power, 2016-03-23 01:26:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-23 01:26:46]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[robliao, 2016-03-23 13:49:51]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-23 13:50:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1825723002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1825723002/60001

[commit-bot: I haz the power, 2016-03-23 13:58:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-23 13:58:37]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[robliao, 2016-03-23 14:05:08]

Patchset #1 (id:20001) has been deleted

[robliao, 2016-03-23 14:05:26]

Patchset #1 (id:40001) has been deleted

[robliao, 2016-03-23 14:35:11]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-23 14:35:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1825723002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1825723002/80001

[robliao, 2016-03-23 14:43:42]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-23 14:43:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1825723002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1825723002/100001

[commit-bot: I haz the power, 2016-03-23 14:53:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-23 14:53:31]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[robliao, 2016-03-23 16:10:02]

Patchset #1 (id:60001) has been deleted

[robliao, 2016-03-23 16:10:14]

Patchset #1 (id:80001) has been deleted

[robliao, 2016-03-23 16:10:40]

Description was changed from

==========
Move ScreenWin to ui/display

BUG=597105
==========

to

==========
Move ScreenWin to ui/display

BUG=597105
==========

[robliao, 2016-03-23 16:10:41]

robliao@chromium.org changed reviewers:
+ oshima@chromium.org

[robliao, 2016-03-23 16:11:21]

oshima: Please review this changelist. Thanks!

[oshima, 2016-03-24 20:43:30]

lgtm

[robliao, 2016-03-24 22:12:09]

robliao@chromium.org changed reviewers:
+ piman@chromium.org, sky@chromium.org

[robliao, 2016-03-24 22:12:10]

Hello OWNERS, please review changes for path patterns underneath your e-mail.
Thanks!

piman@chromium.org: 
content/*

sky@chromium.org:
ui/gfx/win/*
ui/views/*

[tfarina, 2016-03-24 22:18:48]

Could you add a short description to the commit message,
describing why you are moving it there?

The bug may have it, but it is always much better to have
it in the commit message as when blaming all the information
necessary to understand the change will be there.

[piman, 2016-03-24 22:25:48]

lgtm

[robliao, 2016-03-24 23:06:17]

Description was changed from

==========
Move ScreenWin to ui/display

BUG=597105
==========

to

==========
Move ScreenWin to ui/display

ScreenWin along with other Screen related objects is not really about graphics.
As a result, this goes to a new home called ui/display to hold things related to
the screen and display.

BUG=597105
==========

[robliao, 2016-03-24 23:07:43]

Description was changed from

==========
Move ScreenWin to ui/display

ScreenWin along with other Screen related objects is not really about graphics.
As a result, this goes to a new home called ui/display to hold things related to
the screen and display.

BUG=597105
==========

to

==========
Move ScreenWin to ui/display

ScreenWin along with other Screen related objects is not really about graphics. 
As a result, this goes to a new home called ui/display to hold things related to
the screen and display.


BUG=597105
==========

[robliao, 2016-03-24 23:08:09]

On 2016/03/24 22:18:48, tfarina wrote:
> Could you add a short description to the commit message,
> describing why you are moving it there?
> 
> The bug may have it, but it is always much better to have
> it in the commit message as when blaming all the information
> necessary to understand the change will be there.

Done. Added...

ScreenWin along with other Screen related objects is not really about graphics. 
As a result, this goes to a new home called ui/display to hold things related to
the screen and display.

[tfarina, 2016-03-25 13:07:12]

Thanks. 

CL description lgtm.

[sky, 2016-03-25 15:46:17]

I think this makes sense if you're going to move ui/gfx/screen and
ui/gfx/display to the new location. Otherwise it's confusing. Where you planning
on doing that?

[oshima, 2016-03-25 15:54:54]

On 2016/03/25 15:46:17, sky wrote:
> I think this makes sense if you're going to move ui/gfx/screen and
> ui/gfx/display to the new location. Otherwise it's confusing. Where you
planning
> on doing that?

crbug.com/597761

I'm also going to move ash's display impl to ui/display. We're moving impl first
because
it'll have circular dependency.

[robliao, 2016-03-25 15:57:03]

On 2016/03/25 15:46:17, sky wrote:
> I think this makes sense if you're going to move ui/gfx/screen and
> ui/gfx/display to the new location. Otherwise it's confusing. Where you
planning
> on doing that?

ui/gfx/screen and ui/gfx/display will migrate in due time
(http://crbug.com/597761).

ash/display_layout.* will live in ui/display. However, ui/gfx will not be
allowed to depend on ui/display and ScreenWin lives in ui/gfx. As a result,
ScreenWin is a good first candidate to move to the new location.

[sky, 2016-03-25 15:59:47]

LGTM

https://codereview.chromium.org/1825723002/diff/100001/ui/display/BUILD.gn
File ui/display/BUILD.gn (right):

https://codereview.chromium.org/1825723002/diff/100001/ui/display/BUILD.gn#ne...
ui/display/BUILD.gn:137: # This test covers the ChromeOS "display" target as
well as the cross-platform
nit: update comment.

https://codereview.chromium.org/1825723002/diff/100001/ui/display/BUILD.gn#ne...
ui/display/BUILD.gn:139: test("display_unittests") {
Make sure we actually run this test on windows bots too.

https://codereview.chromium.org/1825723002/diff/100001/ui/display/win/screen_...
File ui/display/win/screen_win_display.h (right):

https://codereview.chromium.org/1825723002/diff/100001/ui/display/win/screen_...
ui/display/win/screen_win_display.h:5: #ifndef UI_GFX_WIN_SCREEN_WIN_DISPLAY_H_
update.

[robliao, 2016-03-25 16:00:22]

On 2016/03/25 15:57:03, robliao wrote:
> On 2016/03/25 15:46:17, sky wrote:
> > I think this makes sense if you're going to move ui/gfx/screen and
> > ui/gfx/display to the new location. Otherwise it's confusing. Where you
> planning
> > on doing that?
> 
> ui/gfx/screen and ui/gfx/display will migrate in due time
> (http://crbug.com/597761).
> 
> ash/display_layout.* will live in ui/display. However, ui/gfx will not be
> allowed to depend on ui/display and ScreenWin lives in ui/gfx. As a result,
> ScreenWin is a good first candidate to move to the new location.

Lost in editing: ScreenWin will consume code in ash/display_layout.*,
necessitating the move now.

[robliao, 2016-03-25 16:58:23]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-25 16:58:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1825723002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1825723002/120001

[commit-bot: I haz the power, 2016-03-25 18:25:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-25 18:25:05]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[robliao, 2016-03-25 19:45:43]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-25 19:45:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1825723002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1825723002/120001

[robliao, 2016-03-25 19:46:02]

The CQ bit was unchecked by robliao@chromium.org

[robliao, 2016-03-25 19:51:21]

Patchset #2 (id:120001) has been deleted

[robliao, 2016-03-25 20:01:44]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-25 20:02:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1825723002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1825723002/140001

[robliao, 2016-03-25 20:25:55]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-25 20:26:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1825723002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1825723002/160001

[robliao, 2016-03-25 21:20:48]

Patchset #2 (id:140001) has been deleted

[commit-bot: I haz the power, 2016-03-25 22:51:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-25 22:51:40]

Dry run: This issue passed the CQ dry run.

[robliao, 2016-03-26 00:05:46]

https://codereview.chromium.org/1825723002/diff/100001/ui/display/BUILD.gn
File ui/display/BUILD.gn (right):

https://codereview.chromium.org/1825723002/diff/100001/ui/display/BUILD.gn#ne...
ui/display/BUILD.gn:137: # This test covers the ChromeOS "display" target as
well as the cross-platform
On 2016/03/25 15:59:47, sky wrote:
> nit: update comment.

Done.

https://codereview.chromium.org/1825723002/diff/100001/ui/display/BUILD.gn#ne...
ui/display/BUILD.gn:139: test("display_unittests") {
On 2016/03/25 15:59:47, sky wrote:
> Make sure we actually run this test on windows bots too.

Nice catch. I synchronized display_unittests with all instances of
gfx_unittests, and it's now running on the trybots with the change.

https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64...

https://codereview.chromium.org/1825723002/diff/100001/ui/display/win/screen_...
File ui/display/win/screen_win_display.h (right):

https://codereview.chromium.org/1825723002/diff/100001/ui/display/win/screen_...
ui/display/win/screen_win_display.h:5: #ifndef UI_GFX_WIN_SCREEN_WIN_DISPLAY_H_
On 2016/03/25 15:59:47, sky wrote:
> update.

Done.

[robliao, 2016-03-28 14:17:30]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-28 14:17:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1825723002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1825723002/160001

[commit-bot: I haz the power, 2016-03-28 15:36:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-28 15:36:39]

Dry run: This issue passed the CQ dry run.

[robliao, 2016-03-28 15:53:34]

The CQ bit was checked by robliao@chromium.org

[robliao, 2016-03-28 15:53:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
tfarina@chromium.org, oshima@chromium.org, sky@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1825723002/#ps160001
(title: "Code Review Feedback and Synchronized display_unittests Test Config
Based off of gfx_unittests")

[commit-bot: I haz the power, 2016-03-28 15:53:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1825723002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1825723002/160001

[commit-bot: I haz the power, 2016-03-28 15:59:49]

Description was changed from

==========
Move ScreenWin to ui/display

ScreenWin along with other Screen related objects is not really about graphics. 
As a result, this goes to a new home called ui/display to hold things related to
the screen and display.


BUG=597105
==========

to

==========
Move ScreenWin to ui/display

ScreenWin along with other Screen related objects is not really about graphics. 
As a result, this goes to a new home called ui/display to hold things related to
the screen and display.


BUG=597105
==========

[commit-bot: I haz the power, 2016-03-28 15:59:51]

Committed patchset #2 (id:160001)

[commit-bot: I haz the power, 2016-03-28 16:03:30]

Description was changed from

==========
Move ScreenWin to ui/display

ScreenWin along with other Screen related objects is not really about graphics. 
As a result, this goes to a new home called ui/display to hold things related to
the screen and display.


BUG=597105
==========

to

==========
Move ScreenWin to ui/display

ScreenWin along with other Screen related objects is not really about graphics.
As a result, this goes to a new home called ui/display to hold things related to
the screen and display.

BUG=597105

Committed: https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c
Cr-Commit-Position: refs/heads/master@{#383500}
==========

[commit-bot: I haz the power, 2016-03-28 16:03:32]

Patchset 2 (id:??) landed as
https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c
Cr-Commit-Position: refs/heads/master@{#383500}

[Nico, 2016-03-28 20:22:40]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-03-28 20:22:41]

https://codereview.chromium.org/1825723002/diff/160001/ui/display/BUILD.gn
File ui/display/BUILD.gn (right):

https://codereview.chromium.org/1825723002/diff/160001/ui/display/BUILD.gn#ne...
ui/display/BUILD.gn:110: }
This binary doesn't link on Windows (in gn builds):

https://build.chromium.org/p/chromium.fyi/builders/CrWinClang64%28dbg%29/buil...

LINK : warning LNK4001: no object files specified; libraries used

LINK : error LNK2001: unresolved external symbol _DllMainCRTStartup

./display_test_util.dll : fatal error LNK1120: 1 unresolved externals

Why did this move out of the is_cros block?

[Nico, 2016-03-28 20:27:24]

A revert of this CL (patchset #2 id:160001) has been created in
https://codereview.chromium.org/1834243003/ by thakis@chromium.org.

The reason for reverting is: Doesn't build in gn/win component builds:

LINK : warning LNK4001: no object files specified; libraries used

LINK : error LNK2001: unresolved external symbol _DllMainCRTStartup

./display_test_util.dll : fatal error LNK1120: 1 unresolved externals.

[robliao, 2016-03-28 20:33:57]

https://codereview.chromium.org/1825723002/diff/160001/ui/display/BUILD.gn
File ui/display/BUILD.gn (right):

https://codereview.chromium.org/1825723002/diff/160001/ui/display/BUILD.gn#ne...
ui/display/BUILD.gn:110: }
On 2016/03/28 20:22:41, Nico wrote:
> This binary doesn't link on Windows (in gn builds):
> 
>
https://build.chromium.org/p/chromium.fyi/builders/CrWinClang64%28dbg%29/buil...
> 
> LINK : warning LNK4001: no object files specified; libraries used
> 
> LINK : error LNK2001: unresolved external symbol _DllMainCRTStartup
> 
> ./display_test_util.dll : fatal error LNK1120: 1 unresolved externals
> 
> Why did this move out of the is_cros block?

Looks like I missed this chromeos DLL in my component build. I just built
display_unittests and chrome.

[robliao, 2016-03-28 20:36:10]

On 2016/03/28 20:33:57, robliao wrote:
> https://codereview.chromium.org/1825723002/diff/160001/ui/display/BUILD.gn
> File ui/display/BUILD.gn (right):
> 
>
https://codereview.chromium.org/1825723002/diff/160001/ui/display/BUILD.gn#ne...
> ui/display/BUILD.gn:110: }
> On 2016/03/28 20:22:41, Nico wrote:
> > This binary doesn't link on Windows (in gn builds):
> > 
> >
>
https://build.chromium.org/p/chromium.fyi/builders/CrWinClang64%28dbg%29/buil...
> > 
> > LINK : warning LNK4001: no object files specified; libraries used
> > 
> > LINK : error LNK2001: unresolved external symbol _DllMainCRTStartup
> > 
> > ./display_test_util.dll : fatal error LNK1120: 1 unresolved externals
> > 
> > Why did this move out of the is_cros block?
> 
> Looks like I missed this chromeos DLL in my component build. I just built
> display_unittests and chrome.

*chromeos target

[robliao, 2016-03-29 00:46:34]

Description was changed from

==========
Move ScreenWin to ui/display

ScreenWin along with other Screen related objects is not really about graphics.
As a result, this goes to a new home called ui/display to hold things related to
the screen and display.

BUG=597105

Committed: https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c
Cr-Commit-Position: refs/heads/master@{#383500}
==========

to

==========
Move ScreenWin to ui/display

ScreenWin along with other Screen related objects is not really about graphics.
As a result, this goes to a new home called ui/display to hold things related to
the screen and display.

BUG=597105

Committed: https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c
Cr-Commit-Position: refs/heads/master@{#383500}
==========

[robliao, 2016-03-29 00:52:48]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-29 00:53:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1825723002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1825723002/180001

[commit-bot: I haz the power, 2016-03-29 02:16:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-29 02:16:49]

Dry run: This issue passed the CQ dry run.

[robliao, 2016-03-29 17:23:25]

On 2016/03/29 02:16:49, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

ninja -C out\Debug all now succeeds on my Component GN build (is_component_build
= true) with the latest patchset.

[robliao, 2016-03-29 17:42:16]

The CQ bit was checked by robliao@chromium.org

[robliao, 2016-03-29 17:42:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
tfarina@chromium.org, oshima@chromium.org, sky@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1825723002/#ps180001
(title: "Added is_chromeos guard")

[commit-bot: I haz the power, 2016-03-29 17:42:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1825723002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1825723002/180001

[commit-bot: I haz the power, 2016-03-29 17:49:56]

Description was changed from

==========
Move ScreenWin to ui/display

ScreenWin along with other Screen related objects is not really about graphics.
As a result, this goes to a new home called ui/display to hold things related to
the screen and display.

BUG=597105

Committed: https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c
Cr-Commit-Position: refs/heads/master@{#383500}
==========

to

==========
Move ScreenWin to ui/display

ScreenWin along with other Screen related objects is not really about graphics.
As a result, this goes to a new home called ui/display to hold things related to
the screen and display.

BUG=597105

Committed: https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c
Cr-Commit-Position: refs/heads/master@{#383500}
==========

[commit-bot: I haz the power, 2016-03-29 17:49:58]

Committed patchset #3 (id:180001)

[commit-bot: I haz the power, 2016-03-29 17:51:57]

Description was changed from

==========
Move ScreenWin to ui/display

ScreenWin along with other Screen related objects is not really about graphics.
As a result, this goes to a new home called ui/display to hold things related to
the screen and display.

BUG=597105

Committed: https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c
Cr-Commit-Position: refs/heads/master@{#383500}
==========

to

==========
Move ScreenWin to ui/display

ScreenWin along with other Screen related objects is not really about graphics.
As a result, this goes to a new home called ui/display to hold things related to
the screen and display.

BUG=597105

Committed: https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c
Cr-Commit-Position: refs/heads/master@{#383500}

Committed: https://crrev.com/8d63729c779d6b529efb6d6a4c5985470c68f76b
Cr-Commit-Position: refs/heads/master@{#383761}
==========

[commit-bot: I haz the power, 2016-03-29 17:51:59]

Patchset 3 (id:??) landed as
https://crrev.com/8d63729c779d6b529efb6d6a4c5985470c68f76b
Cr-Commit-Position: refs/heads/master@{#383761}

[Nico, 2016-03-30 12:06:37]

https://codereview.chromium.org/1825723002/diff/180001/testing/buildbot/chrom...
File testing/buildbot/chromium.fyi.json (right):

https://codereview.chromium.org/1825723002/diff/180001/testing/buildbot/chrom...
testing/buildbot/chromium.fyi.json:1635: "test": "display_unittests"
The test was already here for this bot 6 lines above. This bot is now failing
with a "test triggered twice" exception.
(https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxUBSanVptr%20t...)

To prevent mistakes like this, update these files by running
`testing/buildbot/manage.py --convert display_unittests` instead of doing it
manually.

I'll send you a fix reverting this chunk.

[Nico, 2016-03-30 12:07:45]

On 2016/03/30 12:06:37, Nico wrote:
>
https://codereview.chromium.org/1825723002/diff/180001/testing/buildbot/chrom...
> File testing/buildbot/chromium.fyi.json (right):
> 
>
https://codereview.chromium.org/1825723002/diff/180001/testing/buildbot/chrom...
> testing/buildbot/chromium.fyi.json:1635: "test": "display_unittests"
> The test was already here for this bot 6 lines above. This bot is now failing
> with a "test triggered twice" exception.
>
(https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxUBSanVptr%20t...)
> 
> To prevent mistakes like this, update these files by running
> `testing/buildbot/manage.py --convert display_unittests` instead of doing it
> manually.

Actually, this command only converts existing tests to swarming and doesn't help
here. So ignore this bit :-)

> I'll send you a fix reverting this chunk.