Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/display/BUILD.gn

Issue 1825723002: Move ScreenWin to ui/display (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added is_chromeos guard Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« testing/buildbot/chromium.fyi.json ('K') | « testing/buildbot/chromium_trybot.json ('k') | ui/display/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/display/BUILD.gn
diff --git a/ui/display/BUILD.gn b/ui/display/BUILD.gn
index b8c760318babbea63d534cd95c37700e53f5f42e..20ed6af6a142917effea81542f1125a00e3fd97e 100644
--- a/ui/display/BUILD.gn
+++ b/ui/display/BUILD.gn
@@ -5,25 +5,75 @@
import("//build/config/ui.gni")
import("//testing/test.gni")
-if (is_chromeos) {
- component("display") {
- sources = [
- "chromeos/apply_content_protection_task.cc",
- "chromeos/apply_content_protection_task.h",
- "chromeos/configure_displays_task.cc",
- "chromeos/configure_displays_task.h",
- "chromeos/display_configurator.cc",
- "chromeos/display_configurator.h",
- "chromeos/display_layout_manager.h",
- "chromeos/display_snapshot_virtual.cc",
- "chromeos/display_snapshot_virtual.h",
- "chromeos/display_util.cc",
- "chromeos/display_util.h",
- "chromeos/ozone/display_configurator_ozone.cc",
- "chromeos/query_content_protection_task.cc",
- "chromeos/query_content_protection_task.h",
- "chromeos/update_display_configuration_task.cc",
- "chromeos/update_display_configuration_task.h",
+component("display") {
+ sources = [
+ "chromeos/apply_content_protection_task.cc",
+ "chromeos/apply_content_protection_task.h",
+ "chromeos/configure_displays_task.cc",
+ "chromeos/configure_displays_task.h",
+ "chromeos/display_configurator.cc",
+ "chromeos/display_configurator.h",
+ "chromeos/display_layout_manager.h",
+ "chromeos/display_snapshot_virtual.cc",
+ "chromeos/display_snapshot_virtual.h",
+ "chromeos/display_util.cc",
+ "chromeos/display_util.h",
+ "chromeos/ozone/display_configurator_ozone.cc",
+ "chromeos/query_content_protection_task.cc",
+ "chromeos/query_content_protection_task.h",
+ "chromeos/update_display_configuration_task.cc",
+ "chromeos/update_display_configuration_task.h",
+ "chromeos/x11/display_configurator_x11.cc",
+ "chromeos/x11/display_mode_x11.cc",
+ "chromeos/x11/display_mode_x11.h",
+ "chromeos/x11/display_snapshot_x11.cc",
+ "chromeos/x11/display_snapshot_x11.h",
+ "chromeos/x11/display_util_x11.cc",
+ "chromeos/x11/display_util_x11.h",
+ "chromeos/x11/native_display_delegate_x11.cc",
+ "chromeos/x11/native_display_delegate_x11.h",
+ "chromeos/x11/native_display_event_dispatcher_x11.cc",
+ "chromeos/x11/native_display_event_dispatcher_x11.h",
+ "display_export.h",
+ "display_switches.cc",
+ "display_switches.h",
+ "win/display_info.cc",
+ "win/display_info.h",
+ "win/screen_win.cc",
+ "win/screen_win.h",
+ "win/screen_win_display.cc",
+ "win/screen_win_display.h",
+ ]
+
+ defines = [ "DISPLAY_IMPLEMENTATION" ]
+
+ deps = [
+ "//base",
+ "//ui/display/types",
+ "//ui/display/util",
+ "//ui/gfx",
+ "//ui/gfx/geometry",
+ ]
+
+ if (is_chromeos && use_x11) {
+ sources -= [ "chromeos/ozone/display_configurator_ozone.cc" ]
+ configs += [
+ "//build/config/linux:x11",
+ "//build/config/linux:xext",
+ "//build/config/linux:xi",
+ "//build/config/linux:xrandr",
+ ]
+ deps += [ "//ui/events/platform" ]
+ }
+
+ deps += []
+ if (use_x11) {
+ deps += [ "//ui/gfx/x" ]
+ }
+
+ if (is_chromeos && use_ozone) {
+ deps += [ "//ui/ozone" ]
+ sources -= [
"chromeos/x11/display_configurator_x11.cc",
"chromeos/x11/display_mode_x11.cc",
"chromeos/x11/display_mode_x11.h",
@@ -35,55 +85,11 @@ if (is_chromeos) {
"chromeos/x11/native_display_delegate_x11.h",
"chromeos/x11/native_display_event_dispatcher_x11.cc",
"chromeos/x11/native_display_event_dispatcher_x11.h",
- "display_export.h",
- "display_switches.cc",
- "display_switches.h",
- ]
-
- defines = [ "DISPLAY_IMPLEMENTATION" ]
-
- deps = [
- "//base",
- "//ui/display/types",
- "//ui/display/util",
- "//ui/gfx",
- "//ui/gfx/geometry",
]
-
- if (use_x11) {
- sources -= [ "chromeos/ozone/display_configurator_ozone.cc" ]
- configs += [
- "//build/config/linux:x11",
- "//build/config/linux:xext",
- "//build/config/linux:xi",
- "//build/config/linux:xrandr",
- ]
- deps += [ "//ui/events/platform" ]
- }
-
- deps += []
- if (use_x11) {
- deps += [ "//ui/gfx/x" ]
- }
-
- if (use_ozone) {
- deps += [ "//ui/ozone" ]
- sources -= [
- "chromeos/x11/display_configurator_x11.cc",
- "chromeos/x11/display_mode_x11.cc",
- "chromeos/x11/display_mode_x11.h",
- "chromeos/x11/display_snapshot_x11.cc",
- "chromeos/x11/display_snapshot_x11.h",
- "chromeos/x11/display_util_x11.cc",
- "chromeos/x11/display_util_x11.h",
- "chromeos/x11/native_display_delegate_x11.cc",
- "chromeos/x11/native_display_delegate_x11.h",
- "chromeos/x11/native_display_event_dispatcher_x11.cc",
- "chromeos/x11/native_display_event_dispatcher_x11.h",
- ]
- }
}
+}
+if (is_chromeos) {
component("test_util") {
output_name = "display_test_util"
sources = [
@@ -103,35 +109,34 @@ if (is_chromeos) {
"//ui/gfx/geometry",
]
}
+}
- source_set("test_support") {
- testonly = true
- sources = [
- "chromeos/test/action_logger.cc",
- "chromeos/test/action_logger.h",
- "chromeos/test/action_logger_util.cc",
- "chromeos/test/action_logger_util.h",
- "chromeos/test/test_display_layout_manager.cc",
- "chromeos/test/test_display_layout_manager.h",
- "chromeos/test/test_native_display_delegate.cc",
- "chromeos/test/test_native_display_delegate.h",
- ]
+source_set("test_support") {
+ testonly = true
+ sources = [
+ "chromeos/test/action_logger.cc",
+ "chromeos/test/action_logger.h",
+ "chromeos/test/action_logger_util.cc",
+ "chromeos/test/action_logger_util.h",
+ "chromeos/test/test_display_layout_manager.cc",
+ "chromeos/test/test_display_layout_manager.h",
+ "chromeos/test/test_native_display_delegate.cc",
+ "chromeos/test/test_native_display_delegate.h",
+ ]
- public_deps = [
- ":display",
- ]
- deps = [
- "//base",
- "//ui/display/types",
- "//ui/gfx",
- "//ui/gfx:test_support",
- "//ui/gfx/geometry",
- ]
- }
+ public_deps = [
+ ":display",
+ ]
+ deps = [
+ "//base",
+ "//ui/display/types",
+ "//ui/gfx",
+ "//ui/gfx:test_support",
+ "//ui/gfx/geometry",
+ ]
}
-# This test covers the ChromeOS "display" target as well as the cross-platform
-# //display/util target.
+# This test covers all testable components in display.
test("display_unittests") {
sources = [
"chromeos/apply_content_protection_task_unittest.cc",
@@ -143,27 +148,29 @@ test("display_unittests") {
"chromeos/x11/native_display_event_dispatcher_x11_unittest.cc",
"util/display_util_unittest.cc",
"util/edid_parser_unittest.cc",
+ "win/screen_win_unittest.cc",
]
deps = [
+ ":display",
"//base",
"//base/test:run_all_unittests",
+ "//base/test:test_support",
"//testing/gtest",
+ "//ui/display/types",
"//ui/display/util",
+ "//ui/gfx:test_support",
"//ui/gfx/geometry",
]
if (is_chromeos) {
deps += [
- ":display",
":test_support",
":test_util",
- "//base/test:test_support",
- "//ui/display/types",
]
}
- if (use_ozone && is_chromeos) {
+ if (is_chromeos && use_ozone) {
sources -= [
"chromeos/x11/display_util_x11_unittest.cc",
"chromeos/x11/native_display_event_dispatcher_x11_unittest.cc",
« testing/buildbot/chromium.fyi.json ('K') | « testing/buildbot/chromium_trybot.json ('k') | ui/display/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698