Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 182413005: Return refererence from InlineBox::root() (Closed)

Created:
6 years, 9 months ago by ostap
Modified:
6 years, 9 months ago
Reviewers:
esprehn, Inactive
CC:
blink-reviews, zoltan1, dsinclair, sof, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, adamk+blink_chromium.org, jchaffraix+rendering, Inactive, bemjb+rendering_chromium.org, pdr., rwlbuis, adamk
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Return refererence from InlineBox::root() Since there is always root inline box, InlineBox::root() should return reference. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168391

Patch Set 1 #

Patch Set 2 : re-upload because previous patch didn't upload correctly. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -133 lines) Patch
M Source/core/dom/ContainerNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/RenderedPosition.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/VisiblePosition.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/rendering/EllipsisBox.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/InlineBox.h View 3 chunks +11 lines, -2 lines 2 comments Download
M Source/core/rendering/InlineBox.cpp View 3 chunks +9 lines, -9 lines 0 comments Download
M Source/core/rendering/InlineFlowBox.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M Source/core/rendering/InlineTextBox.cpp View 5 chunks +9 lines, -9 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBox.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderInline.cpp View 6 chunks +19 lines, -19 lines 0 comments Download
M Source/core/rendering/RenderLineBoxList.cpp View 6 chunks +16 lines, -16 lines 0 comments Download
M Source/core/rendering/RenderListItem.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderListMarker.cpp View 3 chunks +8 lines, -9 lines 0 comments Download
M Source/core/rendering/RenderReplaced.cpp View 4 chunks +9 lines, -10 lines 0 comments Download
M Source/core/rendering/RenderText.cpp View 8 chunks +16 lines, -20 lines 0 comments Download
M Source/core/rendering/RootInlineBox.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
ostap
6 years, 9 months ago (2014-03-03 20:12:13 UTC) #1
Inactive
https://codereview.chromium.org/182413005/diff/20001/Source/core/rendering/InlineBox.h File Source/core/rendering/InlineBox.h (right): https://codereview.chromium.org/182413005/diff/20001/Source/core/rendering/InlineBox.h#newcode430 Source/core/rendering/InlineBox.h:430: // Allow equality comparisons of InlineBox's by reference or ...
6 years, 9 months ago (2014-03-03 20:25:17 UTC) #2
Inactive
lgtm if esprehn is also OK with this.
6 years, 9 months ago (2014-03-03 20:31:52 UTC) #3
esprehn
lgtm https://codereview.chromium.org/182413005/diff/20001/Source/core/rendering/InlineBox.h File Source/core/rendering/InlineBox.h (right): https://codereview.chromium.org/182413005/diff/20001/Source/core/rendering/InlineBox.h#newcode430 Source/core/rendering/InlineBox.h:430: // Allow equality comparisons of InlineBox's by reference ...
6 years, 9 months ago (2014-03-03 20:57:23 UTC) #4
ostap
The CQ bit was checked by sl.ostapenko@samsung.com
6 years, 9 months ago (2014-03-03 21:10:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/182413005/20001
6 years, 9 months ago (2014-03-03 21:11:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/182413005/20001
6 years, 9 months ago (2014-03-03 23:21:08 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-04 15:25:21 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=25476
6 years, 9 months ago (2014-03-04 15:25:21 UTC) #9
ostap
The CQ bit was checked by sl.ostapenko@samsung.com
6 years, 9 months ago (2014-03-04 15:53:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/182413005/20001
6 years, 9 months ago (2014-03-04 15:53:22 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-04 15:54:52 UTC) #12
Message was sent while issue was closed. 
Change committed as 168391

Powered by Google App Engine
This is Rietveld 408576698