Source/core/dom/ContainerNode.cpp - Issue 182413005: Return refererence from InlineBox::root()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/ContainerNode.cpp

Issue 182413005: Return refererence from InlineBox::root() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: re-upload because previous patch didn't upload correctly. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/ContainerNode.cpp

diff --git a/Source/core/dom/ContainerNode.cpp b/Source/core/dom/ContainerNode.cpp

index b74558de27e07a893df67239ee6e75f8cbd51790..adfe5e6d806cc1c2fa010b5eba18d320104e2bcf 100644

--- a/Source/core/dom/ContainerNode.cpp

+++ b/Source/core/dom/ContainerNode.cpp

@@ -711,7 +711,7 @@ bool ContainerNode::getUpperLeftCorner(FloatPoint& point) const

} else if ((o->isText() && !o->isBR()) || o->isReplaced()) {

point = FloatPoint();

if (o->isText() && toRenderText(o)->firstTextBox()) {

- point.move(toRenderText(o)->linesBoundingBox().x(), toRenderText(o)->firstTextBox()->root()->lineTop());

+ point.move(toRenderText(o)->linesBoundingBox().x(), toRenderText(o)->firstTextBox()->root().lineTop());

} else if (o->isBox()) {

RenderBox* box = toRenderBox(o);

point.moveBy(box->location());

« no previous file with comments | « no previous file | Source/core/editing/RenderedPosition.h » ('j') | Source/core/rendering/InlineBox.h » ('J')