Source/core/rendering/RenderBoxModelObject.cpp - Issue 182413005: Return refererence from InlineBox::root()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBoxModelObject.cpp

Issue 182413005: Return refererence from InlineBox::root() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: re-upload because previous patch didn't upload correctly. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderBoxModelObject.cpp

diff --git a/Source/core/rendering/RenderBoxModelObject.cpp b/Source/core/rendering/RenderBoxModelObject.cpp

index b310eb090c0a68b65dd1298b0c0094415b615904..d5139114fd9650c3557f254bb067a318be6c82f4 100644

--- a/Source/core/rendering/RenderBoxModelObject.cpp

+++ b/Source/core/rendering/RenderBoxModelObject.cpp

@@ -723,8 +723,8 @@ void RenderBoxModelObject::paintFillLayerExtended(const PaintInfo& paintInfo, co

PaintInfo info(context, maskRect, PaintPhaseTextClip, PaintBehaviorForceBlackText, 0);

context->setCompositeOperation(CompositeSourceOver);

if (box) {

- RootInlineBox* root = box->root();

- box->paint(info, LayoutPoint(scrolledPaintRect.x() - box->x(), scrolledPaintRect.y() - box->y()), root->lineTop(), root->lineBottom());

+ RootInlineBox& root = box->root();

+ box->paint(info, LayoutPoint(scrolledPaintRect.x() - box->x(), scrolledPaintRect.y() - box->y()), root.lineTop(), root.lineBottom());

} else {

LayoutSize localOffset = isBox() ? toRenderBox(this)->locationOffset() : LayoutSize();

paint(info, scrolledPaintRect.location() - localOffset);