Source/core/editing/VisiblePosition.cpp - Issue 182413005: Return refererence from InlineBox::root()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/VisiblePosition.cpp

Issue 182413005: Return refererence from InlineBox::root() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: re-upload because previous patch didn't upload correctly. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/VisiblePosition.cpp

diff --git a/Source/core/editing/VisiblePosition.cpp b/Source/core/editing/VisiblePosition.cpp

index 375f273076e196111d0972040b91d2918e5e5e37..a0b7697fa96a6330f951c329c190ea28b4126b18 100644

--- a/Source/core/editing/VisiblePosition.cpp

+++ b/Source/core/editing/VisiblePosition.cpp

@@ -189,7 +189,7 @@ Position VisiblePosition::leftVisuallyDistinctCandidate() const

if (box->direction() == primaryDirection) {

if (!prevBox) {

InlineBox* logicalStart = 0;

- if (primaryDirection == LTR ? box->root()->getLogicalStartBoxWithNode(logicalStart) : box->root()->getLogicalEndBoxWithNode(logicalStart)) {

+ if (primaryDirection == LTR ? box->root().getLogicalStartBoxWithNode(logicalStart) : box->root().getLogicalEndBoxWithNode(logicalStart)) {

box = logicalStart;

renderer = &box->renderer();

offset = primaryDirection == LTR ? box->caretMinOffset() : box->caretMaxOffset();

@@ -354,7 +354,7 @@ Position VisiblePosition::rightVisuallyDistinctCandidate() const

if (box->direction() == primaryDirection) {

if (!nextBox) {

InlineBox* logicalEnd = 0;

- if (primaryDirection == LTR ? box->root()->getLogicalEndBoxWithNode(logicalEnd) : box->root()->getLogicalStartBoxWithNode(logicalEnd)) {

+ if (primaryDirection == LTR ? box->root().getLogicalEndBoxWithNode(logicalEnd) : box->root().getLogicalStartBoxWithNode(logicalEnd)) {

box = logicalEnd;

renderer = &box->renderer();

offset = primaryDirection == LTR ? box->caretMaxOffset() : box->caretMinOffset();