Make max number of vertex attributes be checked dynamically

Make max number of vertex attributes be checked dynamically
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1822343002

Committed: https://skia.googlesource.com/skia/+/7dbd45d2c7427d2c679d6507435d2f0220bf64ef

[bsalomon, 2016-03-23 15:43:45]

Description was changed from

==========
Make max number of vertex attributes be checked dynamically
==========

to

==========
Make max number of vertex attributes be checked dynamically
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-03-23 15:45:19]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com, robertphillips@google.com

[bsalomon, 2016-03-23 15:45:20]

This is motivated by the fact that one of the test contexts in Chromium reports
0 for max vertex attributes, so the assert in GrGLGpu fails. I also just like
doing it this way better.

[robertphillips, 2016-03-23 16:38:16]

lgtm

https://codereview.chromium.org/1822343002/diff/1/src/gpu/GrGpu.h
File src/gpu/GrGpu.h (right):

https://codereview.chromium.org/1822343002/diff/1/src/gpu/GrGpu.h#newcode383
src/gpu/GrGpu.h:383: // GrPrimitiveProcessor.
// A false return value means ...

?

[bsalomon, 2016-03-23 16:59:53]

https://codereview.chromium.org/1822343002/diff/1/src/gpu/GrGpu.h
File src/gpu/GrGpu.h (right):

https://codereview.chromium.org/1822343002/diff/1/src/gpu/GrGpu.h#newcode383
src/gpu/GrGpu.h:383: // GrPrimitiveProcessor.
On 2016/03/23 16:38:16, robertphillips wrote:
> // A false return value means ...
> 
> ?

I added a somewhat generic comment since I imagine the set of limits checked
could easily expand.

[bsalomon, 2016-03-23 17:00:02]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-23 17:00:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1822343002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1822343002/20001

[commit-bot: I haz the power, 2016-03-23 17:15:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-23 17:15:57]

Dry run: This issue passed the CQ dry run.

[bsalomon, 2016-03-23 17:39:54]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-03-23 17:39:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1822343002/#ps20001
(title: "Address comment")

[commit-bot: I haz the power, 2016-03-23 17:39:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1822343002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1822343002/20001

[commit-bot: I haz the power, 2016-03-23 17:40:58]

Description was changed from

==========
Make max number of vertex attributes be checked dynamically
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Make max number of vertex attributes be checked dynamically
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/7dbd45d2c7427d2c679d6507435d2f0220bf64ef
==========

[commit-bot: I haz the power, 2016-03-23 17:40:58]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/7dbd45d2c7427d2c679d6507435d2f0220bf64ef