Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1820363002: Regression test for handling early failure during network download. (Closed)

Created:
4 years, 9 months ago by Łukasz Anforowicz
Modified:
4 years, 9 months ago
CC:
chromium-reviews, asanka
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Regression test for handling early failure during network download. The test would cause a hang/timeout before the fix in crrev.com/1812693002. BUG=594219, 595345 Committed: https://crrev.com/d19c1443dccf9bc0b2cd7b6e9afc2b080e95cd02 Cr-Commit-Position: refs/heads/master@{#382718}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M chrome/browser/download/save_page_browsertest.cc View 2 chunks +9 lines, -3 lines 0 comments Download
M chrome/test/data/save_page/broken-image.htm View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Łukasz Anforowicz
Randy, could you please rubberstamp this CL? (rubberstamp, because these are changes that you've already ...
4 years, 9 months ago (2016-03-22 16:58:12 UTC) #3
Randy Smith (Not in Mondays)
lgtm
4 years, 9 months ago (2016-03-22 21:22:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820363002/1
4 years, 9 months ago (2016-03-22 21:27:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 22:57:09 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 22:58:15 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d19c1443dccf9bc0b2cd7b6e9afc2b080e95cd02
Cr-Commit-Position: refs/heads/master@{#382718}

Powered by Google App Engine
This is Rietveld 408576698