Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Unified Diff: chrome/browser/download/save_page_browsertest.cc

Issue 1820363002: Regression test for handling early failure during network download. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/save_page/broken-image.htm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/save_page_browsertest.cc
diff --git a/chrome/browser/download/save_page_browsertest.cc b/chrome/browser/download/save_page_browsertest.cc
index d5d11deaeea5d8f4ddbfbb23a47f67854152452c..daa8e12528c6175efb5de048cbb5ca7db948cfc5 100644
--- a/chrome/browser/download/save_page_browsertest.cc
+++ b/chrome/browser/download/save_page_browsertest.cc
@@ -1220,8 +1220,14 @@ IN_PROC_BROWSER_TEST_P(SavePageOriginalVsSavedComparisonTest, Style) {
TestOriginalVsSavedPage(save_page_type, url, 6, expected_substrings);
}
-// Test for saving a page with a broken image (see also crbug.com/586680).
+// Test for saving a page with broken subresources:
+// - Broken, undecodable image (see also https://crbug.com/586680)
+// - Broken link, to unresolvable host (see also https://crbug.com/594219)
IN_PROC_BROWSER_TEST_P(SavePageOriginalVsSavedComparisonTest, BrokenImage) {
+ // Clear resolver rules to make sure that *.no.such.host used in the test html
+ // doesn't resolve to 127.0.0.1
+ host_resolver()->ClearRules();
+
content::SavePageType save_page_type = GetParam();
std::string arr[] = {
@@ -1229,8 +1235,8 @@ IN_PROC_BROWSER_TEST_P(SavePageOriginalVsSavedComparisonTest, BrokenImage) {
};
std::vector<std::string> expected_substrings(std::begin(arr), std::end(arr));
- GURL url(
- embedded_test_server()->GetURL("a.com", "/save_page/broken-image.htm"));
+ GURL url(embedded_test_server()->GetURL("127.0.0.1",
+ "/save_page/broken-image.htm"));
TestOriginalVsSavedPage(save_page_type, url, 1, expected_substrings);
}
« no previous file with comments | « no previous file | chrome/test/data/save_page/broken-image.htm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698