Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Unified Diff: chrome/test/data/save_page/broken-image.htm

Issue 1820363002: Regression test for handling early failure during network download. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/save_page_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/save_page/broken-image.htm
diff --git a/chrome/test/data/save_page/broken-image.htm b/chrome/test/data/save_page/broken-image.htm
index 3991b6d56342f06a0e60f721b22c2a35b56a9a6e..9a671b2b6b8734cf850476d556d1ae1211f1b8fe 100644
--- a/chrome/test/data/save_page/broken-image.htm
+++ b/chrome/test/data/save_page/broken-image.htm
@@ -25,5 +25,14 @@
OTOH, this test hopefully covers more than just testing this one
DCHECK - hopefully the broken image scenario hits some other corner
cases as well.
+ <br><br>
+
+ The link to the image below is broken on purpose, to test additional code
+ paths - in particular in this case ResourceHandler::OnResponseStarted
+ is not called at all and the failure is reported directly via
+ ResourceHandler::OnResponseCompleted. See also https://crbug.com/594219.
+ <img src="http://f0b310b1-4038-46a8-ac98-529187682f2d.no.such.host/x.png">
+ <br><br>
+
</body>
</html>
« no previous file with comments | « chrome/browser/download/save_page_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698