chrome/test/data/save_page/broken-image.htm - Issue 1820363002: Regression test for handling early failure during network download.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/save_page/broken-image.htm

Issue 1820363002: Regression test for handling early failure during network download. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <title>	3 <title>

4 Test page for saving a page with a broken image.	4 Test page for saving a page with a broken image.

5 </title>	5 </title>

6 </head>	6 </head>

7 <body>	7 <body>

8 Content verification marker:	8 Content verification marker:

9 broken-image.htm: 1e846775-b3ed-4d9c-a124-029554a1eb9d	9 broken-image.htm: 1e846775-b3ed-4d9c-a124-029554a1eb9d

10 <br>	10 <br>

11 <br>	11 <br>

12	12

13 The picture below is broken on purpose, to test additional code paths:	13 The picture below is broken on purpose, to test additional code paths:

14 <br>	14 <br>

15 <img src="broken-image.png">	15 <img src="broken-image.png">

16 <img src="broken-image.png">	16 <img src="broken-image.png">

17 <br>	17 <br>

18 We have 2 identical img tags above, because this used to trigger a	18 We have 2 identical img tags above, because this used to trigger a

19 DCHECK in MHTMLPartsGenerationDelegate::shouldSkipResource (the	19 DCHECK in MHTMLPartsGenerationDelegate::shouldSkipResource (the

20 DCHECK would think that an img with a broken tag is included twice	20 DCHECK would think that an img with a broken tag is included twice

21 as an MHTML part; MHTML files that have 2 MHTML parts with the same	21 as an MHTML part; MHTML files that have 2 MHTML parts with the same

22 URI render fine in Chrome, but fail in Internet Explorer). See	22 URI render fine in Chrome, but fail in Internet Explorer). See

23 https://crbug.com/586680 for some more details about the DCHECK.	23 https://crbug.com/586680 for some more details about the DCHECK.

24	24

25 OTOH, this test hopefully covers more than just testing this one	25 OTOH, this test hopefully covers more than just testing this one

26 DCHECK - hopefully the broken image scenario hits some other corner	26 DCHECK - hopefully the broken image scenario hits some other corner

27 cases as well.	27 cases as well.

	28 <br><br>

	29

	30 The link to the image below is broken on purpose, to test additional code

	31 paths - in particular in this case ResourceHandler::OnResponseStarted

	32 is not called at all and the failure is reported directly via

	33 ResourceHandler::OnResponseCompleted. See also https://crbug.com/594219.

	34 <img src="http://f0b310b1-4038-46a8-ac98-529187682f2d.no.such.host/x.png">

	35 <br><br>

	36

28 </body>	37 </body>

29 </html>	38 </html>

OLD	NEW

« no previous file with comments | « chrome/browser/download/save_page_browsertest.cc ('k') | no next file » | no next file with comments »