Remove most uses of UnescapeRule::URL_SPECIAL_CHARS outside net/.

ui/base/webui/web_ui_util.cc

Index: ui/base/webui/web_ui_util.cc
diff --git a/ui/base/webui/web_ui_util.cc b/ui/base/webui/web_ui_util.cc
index e83ea68f62615332c13e113b071fe1b26b40697c..773a2ea3ad71fabb91360cc7b4b148513933de27 100644
--- a/ui/base/webui/web_ui_util.cc
+++ b/ui/base/webui/web_ui_util.cc
@@ -91,9 +91,10 @@ bool ParseScaleFactor(const base::StringPiece& identifier,
 void ParsePathAndScale(const GURL& url,
                        std::string* path,
                        float* scale_factor) {
-  *path = net::UnescapeURLComponent(url.path().substr(1),
-                                    (net::UnescapeRule::URL_SPECIAL_CHARS |
-                                     net::UnescapeRule::SPACES));
+  *path = net::UnescapeURLComponent(
+      url.path().substr(1),
+      (net::UnescapeRule::URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS |

[mmenke, 2016/03/23 16:22:29]

I don't think unescaping "/" and "\" gets us anything here, though happy to add
them, if I'm missing something.

[Evan Stade, 2016/03/23 18:58:08]

nit: there is an extra set of parens around the bits

I am not sure offhand, but EXCEPT_PATH_SEPARATORS is probably fine

[mmenke, 2016/03/23 19:06:30]

I just kept the extra parens from before...  I'll go ahead and remove them.

I looked at the code, and it had no special handling of "/", "\", or "%", so
unescaping path separators seemed unnecessary.

+       net::UnescapeRule::SPACES));
   if (scale_factor)
     *scale_factor = 1.0f;