google_apis/gcm/engine/registration_request_unittest.cc - Issue 1820333003: Remove most uses of UnescapeRule::URL_SPECIAL_CHARS outside net/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/engine/registration_request_unittest.cc

Issue 1820333003: Remove most uses of UnescapeRule::URL_SPECIAL_CHARS outside net/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Oops Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/web_contents/web_drag_source_mac.mm ('K') | « content/test/mock_google_streaming_server.cc ('k') | ui/base/webui/web_ui_util.cc » ('j') | ui/base/webui/web_ui_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: google_apis/gcm/engine/registration_request_unittest.cc

diff --git a/google_apis/gcm/engine/registration_request_unittest.cc b/google_apis/gcm/engine/registration_request_unittest.cc

index 9a8ab01a6f6d7155ea0ebb2e5868166fe9d08baa..4dcebd77536be1ceda25fb9579ea3b4672002983 100644

--- a/google_apis/gcm/engine/registration_request_unittest.cc

+++ b/google_apis/gcm/engine/registration_request_unittest.cc

@@ -181,8 +181,10 @@ TEST_F(GCMRegistrationRequestTest, RequestRegistrationWithMultipleSenderIds) {

continue;

ASSERT_TRUE(data_tokenizer.GetNext());

- std::string senders(net::UnescapeURLComponent(data_tokenizer.token(),

- net::UnescapeRule::URL_SPECIAL_CHARS));

+ std::string senders(net::UnescapeURLComponent(

+ data_tokenizer.token(),

+ net::UnescapeRule::PATH_SEPARATORS |

+ net::UnescapeRule::URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS));

base::StringTokenizer sender_tokenizer(senders, ",");

ASSERT_TRUE(sender_tokenizer.GetNext());

EXPECT_EQ("sender1", sender_tokenizer.token());

« content/browser/web_contents/web_drag_source_mac.mm ('K') | « content/test/mock_google_streaming_server.cc ('k') | ui/base/webui/web_ui_util.cc » ('j') | ui/base/webui/web_ui_util.cc » ('J')