Remove most uses of UnescapeRule::URL_SPECIAL_CHARS outside net/.

ui/base/webui/web_ui_util.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/base/webui/web_ui_util.h"
 
 #include <vector>
 
 #include "base/base64.h"
 #include "base/i18n/rtl.h"
@@ skipping 73 matching lines @@
     LOG(WARNING) << "Invalid scale factor format: " << identifier;
     return false;
   }
   *scale_factor = static_cast<float>(scale);
   return true;
 }
 
 void ParsePathAndScale(const GURL& url,
                        std::string* path,
                        float* scale_factor) {
-  *path = net::UnescapeURLComponent(url.path().substr(1),
-                                    (net::UnescapeRule::URL_SPECIAL_CHARS |
-                                     net::UnescapeRule::SPACES));
+  *path = net::UnescapeURLComponent(
+      url.path().substr(1),
+      (net::UnescapeRule::URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS |

[mmenke, 2016/03/23 16:22:29]

I don't think unescaping "/" and "\" gets us anything here, though happy to add
them, if I'm missing something.

[Evan Stade, 2016/03/23 18:58:08]

nit: there is an extra set of parens around the bits

I am not sure offhand, but EXCEPT_PATH_SEPARATORS is probably fine

[mmenke, 2016/03/23 19:06:30]

I just kept the extra parens from before...  I'll go ahead and remove them.

I looked at the code, and it had no special handling of "/", "\", or "%", so
unescaping path separators seemed unnecessary.

+       net::UnescapeRule::SPACES));
   if (scale_factor)
     *scale_factor = 1.0f;
 
   // Detect and parse resource string ending in @<scale>x.
   std::size_t pos = path->rfind('@');
   if (pos != std::string::npos) {
     base::StringPiece stripped_path(*path);
     float factor;
 
     if (ParseScaleFactor(stripped_path.substr(
@@ skipping 72 matching lines @@
           IDS_WEB_FONT_SIZE_XP :
 #endif
           IDS_WEB_FONT_SIZE);
 }
 
 std::string GetTextDirection() {
   return base::i18n::IsRTL() ? "rtl" : "ltr";
 }
 
 }  // namespace webui