content/browser/web_contents/web_drag_source_mac.mm - Issue 1820333003: Remove most uses of UnescapeRule::URL_SPECIAL_CHARS outside net/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_drag_source_mac.mm

Issue 1820333003: Remove most uses of UnescapeRule::URL_SPECIAL_CHARS outside net/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Oops Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/web_contents/web_drag_source_mac.mm

diff --git a/content/browser/web_contents/web_drag_source_mac.mm b/content/browser/web_contents/web_drag_source_mac.mm

index 94ba59908e563664c62fe5d860aa9ba14009d93f..14321f4787920969514adcfabf8c2cead77202ee 100644

--- a/content/browser/web_contents/web_drag_source_mac.mm

+++ b/content/browser/web_contents/web_drag_source_mac.mm

@@ -174,8 +174,8 @@ void PromiseWriterHelper(const DropData& drop_data,

// Strip out any existing escapes and then re-escape uniformly.

if (!url && dropData_->url.SchemeIs(url::kJavaScriptScheme)) {

net::UnescapeRule::Type unescapeRules =

- net::UnescapeRule::SPACES |

- net::UnescapeRule::URL_SPECIAL_CHARS |

+ net::UnescapeRule::SPACES | net::UnescapeRule::PATH_SEPARATORS |

+ net::UnescapeRule::URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS |

mmenke 2016/03/23 16:22:29 Unescaping path separators is always fine for Java

net::UnescapeRule::SPOOFING_AND_CONTROL_CHARS;

std::string unescapedUrlString =

net::UnescapeURLComponent(dropData_->url.spec(), unescapeRules);

« no previous file with comments | « content/browser/indexed_db/indexed_db_browsertest.cc ('k') | content/test/mock_google_streaming_server.cc » ('j') | ui/base/webui/web_ui_util.cc » ('J')