content/test/mock_google_streaming_server.cc - Issue 1820333003: Remove most uses of UnescapeRule::URL_SPECIAL_CHARS outside net/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/mock_google_streaming_server.cc

Issue 1820333003: Remove most uses of UnescapeRule::URL_SPECIAL_CHARS outside net/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Oops Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/web_contents/web_drag_source_mac.mm ('K') | « content/browser/web_contents/web_drag_source_mac.mm ('k') | google_apis/gcm/engine/registration_request_unittest.cc » ('j') | ui/base/webui/web_ui_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/test/mock_google_streaming_server.cc

diff --git a/content/test/mock_google_streaming_server.cc b/content/test/mock_google_streaming_server.cc

index 3484ca3fba003108933d84a373f1b1966ea0cad5..44b48d06db1914e0725cdb7cf5e26950565268be 100644

--- a/content/test/mock_google_streaming_server.cc

+++ b/content/test/mock_google_streaming_server.cc

@@ -46,9 +46,9 @@ void MockGoogleStreamingServer::OnRequestStart(int fetcher_id) {

// Extract request argument from the the request URI.

std::string query = GetURLFetcher(true)->GetOriginalURL().query();

const net::UnescapeRule::Type kUnescapeAll =

- net::UnescapeRule::NORMAL |

- net::UnescapeRule::SPACES |

- net::UnescapeRule::URL_SPECIAL_CHARS |

+ net::UnescapeRule::NORMAL | net::UnescapeRule::SPACES |

+ net::UnescapeRule::PATH_SEPARATORS |

+ net::UnescapeRule::URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS |

net::UnescapeRule::REPLACE_PLUS_WITH_SPACE;

for (const base::StringPiece& query_param :

base::SplitStringPiece(query, "&", base::KEEP_WHITESPACE,