Remove support for legacy const, part 1

Remove support for legacy const, part 1

Now that ES2015 const has shipped, in Chrome 49, legacy const declarations
are no more. This lets us remove a bunch of code from many parts of the
codebase.

In this patch, I remove parser support for generating legacy const variables
from const declarations. This also removes the special "illegal declaration"
bit from Scope, which has ripples into all compiler backends.

Also gone are any tests which relied on legacy const declarations.

Note that we do still generate a Variable in mode CONST_LEGACY in one case:
function name bindings in sloppy mode. The likely fix there is to add a new
Variable::Kind for this case and handle it appropriately for stores in each
backend, but I leave that for a later patch to make this one completely
subtractive.

Committed: https://crrev.com/ed18aa65ea9247a0940fe6b8890962e49c765c03
Cr-Commit-Position: refs/heads/master@{#35002}

[adamk, 2016-03-21 20:43:46]

adamk@chromium.org changed reviewers:
+ bmeurer@chromium.org, littledan@chromium.org

[Michael Starzinger, 2016-03-21 20:51:16]

mstarzinger@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Michael Starzinger, 2016-03-21 20:51:16]

LGTM on the various back-ends and on the compiler pipeline, didn't look at
parsing. Minus ~2000LoC, now that is what I call a nice CL. Love it!

[Benedikt Meurer, 2016-03-22 06:04:12]

Awesome. LGTM!

[rmcilroy, 2016-03-22 12:19:10]

rmcilroy@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[rmcilroy, 2016-03-22 12:19:11]

Awesome, LGTM. One nit:

https://codereview.chromium.org/1819123002/diff/1/test/cctest/interpreter/tes...
File test/cctest/interpreter/test-bytecode-generator.cc (left):

https://codereview.chromium.org/1819123002/diff/1/test/cctest/interpreter/tes...
test/cctest/interpreter/test-bytecode-generator.cc:2023:
LoadGolden("LegacyConstVariable.golden"));
Could you delete LegacyConstVariable.golden too please?

[adamk, 2016-03-22 17:21:58]

https://codereview.chromium.org/1819123002/diff/1/test/cctest/interpreter/tes...
File test/cctest/interpreter/test-bytecode-generator.cc (left):

https://codereview.chromium.org/1819123002/diff/1/test/cctest/interpreter/tes...
test/cctest/interpreter/test-bytecode-generator.cc:2023:
LoadGolden("LegacyConstVariable.golden"));
On 2016/03/22 12:19:11, rmcilroy wrote:
> Could you delete LegacyConstVariable.golden too please?

Done.

[adamk, 2016-03-22 17:22:21]

The CQ bit was checked by adamk@chromium.org

[adamk, 2016-03-22 17:22:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, mstarzinger@chromium.org, rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1819123002/#ps20001
(title: "Rebased, deleted one more file")

[commit-bot: I haz the power, 2016-03-22 17:22:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1819123002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1819123002/20001

[commit-bot: I haz the power, 2016-03-22 17:51:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-22 17:52:21]

Description was changed from

==========
Remove support for legacy const, part 1

Now that ES2015 const has shipped, in Chrome 49, legacy const declarations
are no more. This lets us remove a bunch of code from many parts of the
codebase.

In this patch, I remove parser support for generating legacy const variables
from const declarations. This also removes the special "illegal declaration"
bit from Scope, which has ripples into all compiler backends.

Also gone are any tests which relied on legacy const declarations.

Note that we do still generate a Variable in mode CONST_LEGACY in one case:
function name bindings in sloppy mode. The likely fix there is to add a new
Variable::Kind for this case and handle it appropriately for stores in each
backend, but I leave that for a later patch to make this one completely
subtractive.
==========

to

==========
Remove support for legacy const, part 1

Now that ES2015 const has shipped, in Chrome 49, legacy const declarations
are no more. This lets us remove a bunch of code from many parts of the
codebase.

In this patch, I remove parser support for generating legacy const variables
from const declarations. This also removes the special "illegal declaration"
bit from Scope, which has ripples into all compiler backends.

Also gone are any tests which relied on legacy const declarations.

Note that we do still generate a Variable in mode CONST_LEGACY in one case:
function name bindings in sloppy mode. The likely fix there is to add a new
Variable::Kind for this case and handle it appropriately for stores in each
backend, but I leave that for a later patch to make this one completely
subtractive.

Committed: https://crrev.com/ed18aa65ea9247a0940fe6b8890962e49c765c03
Cr-Commit-Position: refs/heads/master@{#35002}
==========

[commit-bot: I haz the power, 2016-03-22 17:52:23]

Patchset 2 (id:??) landed as
https://crrev.com/ed18aa65ea9247a0940fe6b8890962e49c765c03
Cr-Commit-Position: refs/heads/master@{#35002}