Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: test/cctest/interpreter/generate-bytecode-expectations.cc

Issue 1819123002: Remove support for legacy const, part 1 (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebased, deleted one more file Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/interpreter/generate-bytecode-expectations.cc
diff --git a/test/cctest/interpreter/generate-bytecode-expectations.cc b/test/cctest/interpreter/generate-bytecode-expectations.cc
index 13908f8177c55eba3ffe4ff43945dd50385430a3..92ba9ba0bd49d1caa318243762adbaaa7a1569b1 100644
--- a/test/cctest/interpreter/generate-bytecode-expectations.cc
+++ b/test/cctest/interpreter/generate-bytecode-expectations.cc
@@ -43,7 +43,6 @@ class ProgramOptions final {
wrap_(true),
execute_(true),
top_level_(false),
- legacy_const_(false),
do_expressions_(false),
verbose_(false),
const_pool_type_(
@@ -64,7 +63,6 @@ class ProgramOptions final {
bool wrap() const { return wrap_; }
bool execute() const { return execute_; }
bool top_level() const { return top_level_; }
- bool legacy_const() const { return legacy_const_; }
bool do_expressions() const { return do_expressions_; }
bool verbose() const { return verbose_; }
bool suppress_runtime_errors() const { return rebaseline_ && !verbose_; }
@@ -84,7 +82,6 @@ class ProgramOptions final {
bool wrap_;
bool execute_;
bool top_level_;
- bool legacy_const_;
bool do_expressions_;
bool verbose_;
BytecodeExpectationsPrinter::ConstantPoolType const_pool_type_;
@@ -213,8 +210,6 @@ ProgramOptions ProgramOptions::FromCommandLine(int argc, char** argv) {
options.execute_ = false;
} else if (strcmp(argv[i], "--top-level") == 0) {
options.top_level_ = true;
- } else if (strcmp(argv[i], "--legacy-const") == 0) {
- options.legacy_const_ = true;
} else if (strcmp(argv[i], "--do-expressions") == 0) {
options.do_expressions_ = true;
} else if (strcmp(argv[i], "--verbose") == 0) {
@@ -319,8 +314,6 @@ void ProgramOptions::UpdateFromHeader(std::istream& stream) {
test_function_name_ = line.c_str() + 20;
} else if (line.compare(0, 11, "top level: ") == 0) {
top_level_ = ParseBoolean(line.c_str() + 11);
- } else if (line.compare(0, 14, "legacy const: ") == 0) {
- legacy_const_ = ParseBoolean(line.c_str() + 14);
} else if (line.compare(0, 16, "do expressions: ") == 0) {
do_expressions_ = ParseBoolean(line.c_str() + 16);
} else if (line == "---") {
@@ -346,7 +339,6 @@ void ProgramOptions::PrintHeader(std::ostream& stream) const { // NOLINT
}
if (top_level_) stream << "\ntop level: yes";
- if (legacy_const_) stream << "\nlegacy const: yes";
if (do_expressions_) stream << "\ndo expressions: yes";
stream << "\n\n";
@@ -452,7 +444,6 @@ void GenerateExpectationsFile(std::ostream& stream, // NOLINT
printer.set_test_function_name(options.test_function_name());
}
- if (options.legacy_const()) i::FLAG_legacy_const = true;
if (options.do_expressions()) i::FLAG_harmony_do_expressions = true;
stream << "#\n# Autogenerated by generate-bytecode-expectations.\n#\n\n";
@@ -461,7 +452,6 @@ void GenerateExpectationsFile(std::ostream& stream, // NOLINT
printer.PrintExpectation(stream, snippet);
}
- i::FLAG_legacy_const = false;
i::FLAG_harmony_do_expressions = false;
}
@@ -506,7 +496,6 @@ void PrintUsage(const char* exec_path) {
" --test-function-name=foo "
"Specify the name of the test function.\n"
" --top-level Process top level code, not the top-level function.\n"
- " --legacy-const Enable legacy_const flag.\n"
" --do-expressions Enable harmony_do_expressions flag.\n"
" --output=file.name\n"
" Specify the output file. If not specified, output goes to "

Powered by Google App Engine
This is Rietveld 408576698