Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1184)

Unified Diff: test/cctest/interpreter/test-bytecode-generator.cc

Issue 1819123002: Remove support for legacy const, part 1 (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebased, deleted one more file Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/interpreter/test-bytecode-generator.cc
diff --git a/test/cctest/interpreter/test-bytecode-generator.cc b/test/cctest/interpreter/test-bytecode-generator.cc
index d2dfdddcf359c129875db5f0c5a912afe77cc61f..2519f25142a9065193b11a551cb83707331c97fd 100644
--- a/test/cctest/interpreter/test-bytecode-generator.cc
+++ b/test/cctest/interpreter/test-bytecode-generator.cc
@@ -1496,24 +1496,6 @@ TEST(CreateRestParameter) {
LoadGolden("CreateRestParameter.golden"));
}
-TEST(IllegalRedeclaration) {
- bool old_legacy_const_flag = FLAG_legacy_const;
- FLAG_legacy_const = true;
-
- CHECK_GE(MessageTemplate::kVarRedeclaration, 128);
- // Must adapt bytecode if this changes.
-
- InitializedIgnitionHandleScope scope;
- BytecodeExpectationsPrinter printer(CcTest::isolate(),
- ConstantPoolType::kMixed);
- const char* snippets[] = {"const a = 1; { var a = 2; }"};
-
- CHECK_EQ(BuildActual(printer, snippets),
- LoadGolden("IllegalRedeclaration.golden"));
-
- FLAG_legacy_const = old_legacy_const_flag;
-}
-
TEST(ForIn) {
InitializedIgnitionHandleScope scope;
BytecodeExpectationsPrinter printer(CcTest::isolate(),
@@ -2002,29 +1984,6 @@ TEST(LetVariable) {
CHECK_EQ(BuildActual(printer, snippets), LoadGolden("LetVariable.golden"));
}
-TEST(LegacyConstVariable) {
- bool old_legacy_const_flag = FLAG_legacy_const;
- FLAG_legacy_const = true;
-
- InitializedIgnitionHandleScope scope;
- BytecodeExpectationsPrinter printer(CcTest::isolate(),
- ConstantPoolType::kString);
- const char* snippets[] = {
- "const x = 10;",
-
- "const x = 10; return x;",
-
- "const x = ( x = 20);",
-
- "const x = 10; x = 20;",
- };
-
- CHECK_EQ(BuildActual(printer, snippets),
- LoadGolden("LegacyConstVariable.golden"));
-
- FLAG_legacy_const = old_legacy_const_flag;
-}
-
TEST(ConstVariableContextSlot) {
// TODO(mythria): Add tests for initialization of this via super calls.
// TODO(mythria): Add tests that walk the context chain.
« no previous file with comments | « test/cctest/interpreter/generate-bytecode-expectations.cc ('k') | test/cctest/interpreter/test-interpreter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698