Remove support for legacy const, part 1

test/cctest/interpreter/test-bytecode-generator.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <fstream>
 
 #include "src/v8.h"
 
 #include "src/compiler.h"
 #include "src/interpreter/bytecode-array-iterator.h"
@@ skipping 1478 matching lines @@
 
       "function f(a, ...restArgs) { return restArgs[0]; }",
 
       "function f(a, ...restArgs) { return restArgs[0] + arguments[0]; }",
   };
 
   CHECK_EQ(BuildActual(printer, snippets, "", "\nf();"),
            LoadGolden("CreateRestParameter.golden"));
 }
 
-TEST(IllegalRedeclaration) {
-  bool old_legacy_const_flag = FLAG_legacy_const;
-  FLAG_legacy_const = true;
-
-  CHECK_GE(MessageTemplate::kVarRedeclaration, 128);
-  // Must adapt bytecode if this changes.
-
-  InitializedIgnitionHandleScope scope;
-  BytecodeExpectationsPrinter printer(CcTest::isolate(),
-                                      ConstantPoolType::kMixed);
-  const char* snippets[] = {"const a = 1; { var a = 2; }"};
-
-  CHECK_EQ(BuildActual(printer, snippets),
-           LoadGolden("IllegalRedeclaration.golden"));
-
-  FLAG_legacy_const = old_legacy_const_flag;
-}
-
 TEST(ForIn) {
   InitializedIgnitionHandleScope scope;
   BytecodeExpectationsPrinter printer(CcTest::isolate(),
                                       ConstantPoolType::kMixed);
   const char* snippets[] = {
       "for (var p in null) {}",
 
       "for (var p in undefined) {}",
 
       "for (var p in undefined) {}",
@@ skipping 468 matching lines @@
       "let x = 10; return x;",
 
       "let x = (x = 20);",
 
       "let x = 10; x = 20;",
   };
 
   CHECK_EQ(BuildActual(printer, snippets), LoadGolden("LetVariable.golden"));
 }
 
-TEST(LegacyConstVariable) {
-  bool old_legacy_const_flag = FLAG_legacy_const;
-  FLAG_legacy_const = true;
-
-  InitializedIgnitionHandleScope scope;
-  BytecodeExpectationsPrinter printer(CcTest::isolate(),
-                                      ConstantPoolType::kString);
-  const char* snippets[] = {
-      "const x = 10;",
-
-      "const x = 10; return x;",
-
-      "const x = ( x = 20);",
-
-      "const x = 10; x = 20;",
-  };
-
-  CHECK_EQ(BuildActual(printer, snippets),
-           LoadGolden("LegacyConstVariable.golden"));
-
-  FLAG_legacy_const = old_legacy_const_flag;
-}
-
 TEST(ConstVariableContextSlot) {
   // TODO(mythria): Add tests for initialization of this via super calls.
   // TODO(mythria): Add tests that walk the context chain.
   InitializedIgnitionHandleScope scope;
   BytecodeExpectationsPrinter printer(CcTest::isolate(),
                                       ConstantPoolType::kMixed);
   const char* snippets[] = {
       "const x = 10; function f1() {return x;}",
 
       "const x = 10; function f1() {return x;} return x;",
@@ skipping 153 matching lines @@
       "})();\n",
   };
 
   CHECK_EQ(BuildActual(printer, snippets),
            LoadGolden("ClassAndSuperClass.golden"));
 }
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8