Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1818923002: [stubs] Split ToNumberStub into reusable subparts. (Closed)

Created:
4 years, 9 months ago by Benedikt Meurer
Modified:
4 years, 9 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Split ToNumberStub into reusable subparts. Split ToNumberStub into the entry ToNumberStub, and two new stubs, StringToNumberStub and NonNumberToNumberStub, which can be used when we already know something about the input (i.e. in various branches of the code stubs, or in TurboFan graphs). Also introduce an appropriate StringToNumber simplified operator for TurboFan, that is pure and is lowered to an invocation of the newly added StringToNumberStub. R=jarin@chromium.org Committed: https://crrev.com/b7aa4c3ab35b3a28fee7fc49bf7aa1003d66959e Cr-Commit-Position: refs/heads/master@{#34922}

Patch Set 1 #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+345 lines, -101 lines) Patch
M src/arm/code-stubs-arm.cc View 2 chunks +33 lines, -18 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 2 chunks +33 lines, -16 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/bailout-reason.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/code-factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/code-factory.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/code-stubs.h View 2 chunks +18 lines, -0 lines 0 comments Download
M src/code-stubs.cc View 5 chunks +10 lines, -5 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 1 chunk +17 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +30 lines, -13 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +36 lines, -17 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +36 lines, -17 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +30 lines, -13 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 9 months ago (2016-03-21 07:56:37 UTC) #1
Benedikt Meurer
Hey Jaro, Some disassembling of ToNumberStub. Please take a look. Thanks, Benedikt
4 years, 9 months ago (2016-03-21 08:01:39 UTC) #2
Jarin
lgtm
4 years, 9 months ago (2016-03-21 08:46:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1818923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1818923002/20001
4 years, 9 months ago (2016-03-21 09:03:20 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-21 09:05:28 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 09:05:55 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b7aa4c3ab35b3a28fee7fc49bf7aa1003d66959e
Cr-Commit-Position: refs/heads/master@{#34922}

Powered by Google App Engine
This is Rietveld 408576698