Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Side by Side Diff: test/cctest/compiler/test-js-typed-lowering.cc

Issue 1818923002: [stubs] Split ToNumberStub into reusable subparts. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x64/macro-assembler-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compilation-dependencies.h" 5 #include "src/compilation-dependencies.h"
6 #include "src/compiler/js-graph.h" 6 #include "src/compiler/js-graph.h"
7 #include "src/compiler/js-typed-lowering.h" 7 #include "src/compiler/js-typed-lowering.h"
8 #include "src/compiler/machine-operator.h" 8 #include "src/compiler/machine-operator.h"
9 #include "src/compiler/node-properties.h" 9 #include "src/compiler/node-properties.h"
10 #include "src/compiler/opcodes.h" 10 #include "src/compiler/opcodes.h"
(...skipping 957 matching lines...) Expand 10 before | Expand all | Expand 10 after
968 968
969 const Operator* ops[] = { 969 const Operator* ops[] = {
970 R.javascript.GreaterThan(), R.simplified.NumberLessThan(), 970 R.javascript.GreaterThan(), R.simplified.NumberLessThan(),
971 R.javascript.GreaterThanOrEqual(), R.simplified.NumberLessThanOrEqual(), 971 R.javascript.GreaterThanOrEqual(), R.simplified.NumberLessThanOrEqual(),
972 }; 972 };
973 973
974 for (size_t j = 0; j < arraysize(ops); j += 2) { 974 for (size_t j = 0; j < arraysize(ops); j += 2) {
975 BinopEffectsTester B(ops[j], Type::Symbol(), Type::String()); 975 BinopEffectsTester B(ops[j], Type::Symbol(), Type::String());
976 CHECK_EQ(ops[j + 1]->opcode(), B.result->op()->opcode()); 976 CHECK_EQ(ops[j + 1]->opcode(), B.result->op()->opcode());
977 977
978 Node* i0 = B.CheckConvertedInput(IrOpcode::kJSToNumber, 0, true); 978 Node* i0 = B.CheckConvertedInput(IrOpcode::kStringToNumber, 0, false);
979 Node* i1 = B.CheckConvertedInput(IrOpcode::kJSToNumber, 1, true); 979 Node* i1 = B.CheckConvertedInput(IrOpcode::kJSToNumber, 1, true);
980 980
981 // Inputs should be commuted. 981 // Inputs should be commuted.
982 CHECK_EQ(B.p1, i0->InputAt(0)); 982 CHECK_EQ(B.p1, i0->InputAt(0));
983 CHECK_EQ(B.p0, i1->InputAt(0)); 983 CHECK_EQ(B.p0, i1->InputAt(0));
984 984
985 // But effects should be ordered start -> i1 -> effect_use 985 // But effects should be ordered start -> i1 -> effect_use
986 B.CheckEffectOrdering(i1); 986 B.CheckEffectOrdering(i1);
987 } 987 }
988 988
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
1218 CHECK_EQ(p1, r->InputAt(1)); 1218 CHECK_EQ(p1, r->InputAt(1));
1219 } 1219 }
1220 } 1220 }
1221 } 1221 }
1222 } 1222 }
1223 } 1223 }
1224 1224
1225 } // namespace compiler 1225 } // namespace compiler
1226 } // namespace internal 1226 } // namespace internal
1227 } // namespace v8 1227 } // namespace v8
OLDNEW
« no previous file with comments | « src/x64/macro-assembler-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698