test/cctest/compiler/test-js-typed-lowering.cc - Issue 1818923002: [stubs] Split ToNumberStub into reusable subparts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/compiler/test-js-typed-lowering.cc

Issue 1818923002: [stubs] Split ToNumberStub into reusable subparts. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: REBASE Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/compiler/test-js-typed-lowering.cc

diff --git a/test/cctest/compiler/test-js-typed-lowering.cc b/test/cctest/compiler/test-js-typed-lowering.cc

index 24db6a532eebbb49391a4b33e1cdebb806cc3ede..0075de53293accfeec9f120d2630e1e8bcfa0232 100644

--- a/test/cctest/compiler/test-js-typed-lowering.cc

+++ b/test/cctest/compiler/test-js-typed-lowering.cc

@@ -975,7 +975,7 @@ TEST(OrderCompareEffects) {

BinopEffectsTester B(ops[j], Type::Symbol(), Type::String());

CHECK_EQ(ops[j + 1]->opcode(), B.result->op()->opcode());

- Node* i0 = B.CheckConvertedInput(IrOpcode::kJSToNumber, 0, true);

+ Node* i0 = B.CheckConvertedInput(IrOpcode::kStringToNumber, 0, false);

Node* i1 = B.CheckConvertedInput(IrOpcode::kJSToNumber, 1, true);

// Inputs should be commuted.

« no previous file with comments | « src/x64/macro-assembler-x64.cc ('k') | no next file » | no next file with comments »