[stubs] Split ToNumberStub into reusable subparts.

src/code-stubs.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/code-stubs.h"
 
 #include <sstream>
 
 #include "src/bootstrapper.h"
 #include "src/code-factory.h"
@@ skipping 581 matching lines @@
           var_fcmp_rhs.Bind(assembler->LoadHeapNumberValue(rhs));
           assembler->Goto(&do_fcmp);
         }
 
         assembler->Bind(&if_rhsisnotnumber);
         {
           // Convert the {rhs} to a Number; we don't need to perform the
           // dedicated ToPrimitive(rhs, hint Number) operation, as the
           // ToNumber(rhs) will by itself already invoke ToPrimitive with
           // a Number hint.
-          Callable callable = CodeFactory::ToNumber(assembler->isolate());
+          Callable callable =
+              CodeFactory::NonNumberToNumber(assembler->isolate());
           var_rhs.Bind(assembler->CallStub(callable, context, rhs));
           assembler->Goto(&loop);
         }
       }
     }
 
     assembler->Bind(&if_lhsisnotsmi);
     {
       // Load the HeapNumber map for later comparisons.
       Node* number_map = assembler->HeapNumberMapConstant();
@@ skipping 22 matching lines @@
           var_fcmp_rhs.Bind(assembler->SmiToFloat64(rhs));
           assembler->Goto(&do_fcmp);
         }
 
         assembler->Bind(&if_lhsisnotnumber);
         {
           // Convert the {lhs} to a Number; we don't need to perform the
           // dedicated ToPrimitive(lhs, hint Number) operation, as the
           // ToNumber(lhs) will by itself already invoke ToPrimitive with
           // a Number hint.
-          Callable callable = CodeFactory::ToNumber(assembler->isolate());
+          Callable callable =
+              CodeFactory::NonNumberToNumber(assembler->isolate());
           var_lhs.Bind(assembler->CallStub(callable, context, lhs));
           assembler->Goto(&loop);
         }
       }
 
       assembler->Bind(&if_rhsisnotsmi);
       {
         // Load the map of {rhs}.
         Node* rhs_map = assembler->LoadMap(rhs);
 
@@ skipping 18 matching lines @@
             var_fcmp_rhs.Bind(assembler->LoadHeapNumberValue(rhs));
             assembler->Goto(&do_fcmp);
           }
 
           assembler->Bind(&if_rhsisnotnumber);
           {
             // Convert the {rhs} to a Number; we don't need to perform
             // dedicated ToPrimitive(rhs, hint Number) operation, as the
             // ToNumber(rhs) will by itself already invoke ToPrimitive with
             // a Number hint.
-            Callable callable = CodeFactory::ToNumber(assembler->isolate());
+            Callable callable =
+                CodeFactory::NonNumberToNumber(assembler->isolate());
             var_rhs.Bind(assembler->CallStub(callable, context, rhs));
             assembler->Goto(&loop);
           }
         }
 
         assembler->Bind(&if_lhsisnotnumber);
         {
           // Load the instance type of {lhs}.
           Node* lhs_instance_type = assembler->LoadMapInstanceType(lhs_map);
 
@@ skipping 370 matching lines @@
             Label if_rhsisstring(assembler, Label::kDeferred),
                 if_rhsisnotstring(assembler, Label::kDeferred);
             assembler->Branch(assembler->Int32LessThan(
                                   rhs_instance_type, assembler->Int32Constant(
                                                          FIRST_NONSTRING_TYPE)),
                               &if_rhsisstring, &if_rhsisnotstring);
 
             assembler->Bind(&if_rhsisstring);
             {
               // Convert the {rhs} to a Number.
-              Callable callable = CodeFactory::ToNumber(assembler->isolate());
+              Callable callable =
+                  CodeFactory::StringToNumber(assembler->isolate());
               var_rhs.Bind(assembler->CallStub(callable, context, rhs));
               assembler->Goto(&loop);
             }
 
             assembler->Bind(&if_rhsisnotstring);
             {
               // Check if the {rhs} is a Boolean.
               Node* boolean_map = assembler->BooleanMapConstant();
               Label if_rhsisboolean(assembler, Label::kDeferred),
                   if_rhsisnotboolean(assembler, Label::kDeferred);
@@ skipping 154 matching lines @@
                   assembler->Int32LessThan(
                       rhs_instance_type,
                       assembler->Int32Constant(FIRST_NONSTRING_TYPE)),
                   &if_rhsisstring, &if_rhsisnotstring);
 
               assembler->Bind(&if_rhsisstring);
               {
                 // The {rhs} is a String and the {lhs} is a HeapNumber; we need
                 // to convert the {rhs} to a Number and compare the output to
                 // the Number on the {lhs}.
-                Callable callable = CodeFactory::ToNumber(assembler->isolate());
+                Callable callable =
+                    CodeFactory::StringToNumber(assembler->isolate());
                 var_rhs.Bind(assembler->CallStub(callable, context, rhs));
                 assembler->Goto(&loop);
               }
 
               assembler->Bind(&if_rhsisnotstring);
               {
                 // Check if the {rhs} is a JSReceiver.
                 Label if_rhsisreceiver(assembler, Label::kDeferred),
                     if_rhsisnotreceiver(assembler);
                 STATIC_ASSERT(LAST_TYPE == LAST_JS_RECEIVER_TYPE);
@@ skipping 1494 matching lines @@
   if (type->Is(Type::UntaggedPointer())) {
     return Representation::External();
   }
 
   DCHECK(!type->Is(Type::Untagged()));
   return Representation::Tagged();
 }
 
 }  // namespace internal
 }  // namespace v8