Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 181783006: Fix bad type-inferrence for is-checks in logical and/or expressions. (Closed)

Created:
6 years, 10 months ago by floitsch
Modified:
6 years, 9 months ago
Reviewers:
ngeoffray, sra1
CC:
reviews_dartlang.org, herhut
Visibility:
Public.

Description

Fix bad type-inferrence for is-checks in logical and/or expressions.

Patch Set 1 #

Patch Set 2 : Add another test. #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -2 lines) Patch
M sdk/lib/_internal/compiler/implementation/inferrer/inferrer_visitor.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_and_or_test.dart View 3 chunks +11 lines, -0 lines 0 comments Download
A tests/language/logical_expression3_test.dart View 1 1 chunk +28 lines, -0 lines 4 comments Download

Messages

Total messages: 5 (0 generated)
floitsch
6 years, 10 months ago (2014-02-26 23:11:57 UTC) #1
sra1
lgtm. I have exactly the same comments of this CL as I have for its ...
6 years, 10 months ago (2014-02-27 03:13:58 UTC) #2
ngeoffray
LGTM https://codereview.chromium.org/181783006/diff/20001/tests/language/logical_expression3_test.dart File tests/language/logical_expression3_test.dart (right): https://codereview.chromium.org/181783006/diff/20001/tests/language/logical_expression3_test.dart#newcode3 tests/language/logical_expression3_test.dart:3: // BSD-style license that can be found in ...
6 years, 10 months ago (2014-02-27 10:47:31 UTC) #3
floitsch
https://codereview.chromium.org/181783006/diff/20001/tests/language/logical_expression3_test.dart File tests/language/logical_expression3_test.dart (right): https://codereview.chromium.org/181783006/diff/20001/tests/language/logical_expression3_test.dart#newcode3 tests/language/logical_expression3_test.dart:3: // BSD-style license that can be found in the ...
6 years, 9 months ago (2014-02-27 15:25:45 UTC) #4
floitsch
6 years, 9 months ago (2014-02-27 15:26:00 UTC) #5 
Merged this CL into https://codereview.chromium.org/182373002/

Closing.

Powered by Google App Engine
This is Rietveld 408576698