Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: tests/language/logical_expression3_test.dart

Issue 181783006: Fix bad type-inferrence for is-checks in logical and/or expressions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add another test. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/compiler/dart2js/simple_inferrer_and_or_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/logical_expression3_test.dart
diff --git a/tests/language/logical_expression3_test.dart b/tests/language/logical_expression3_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..bcbf39e712b62036d578da6c20e334c858888df3
--- /dev/null
+++ b/tests/language/logical_expression3_test.dart
@@ -0,0 +1,28 @@
+// Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
ngeoffray 2014/02/27 10:47:31 New line?
floitsch 2014/02/27 15:25:45 done. in https://codereview.chromium.org/182373002
+// Dart test program for testing if statement.
ngeoffray 2014/02/27 10:47:31 Rewrite comment.
floitsch 2014/02/27 15:25:45 done. in https://codereview.chromium.org/182373002
+
+import "package:expect/expect.dart";
+
+// For logical-or conditions with an and-expression in the lhs, dart2js
+// unconditionally propagated not-is-checks of the logical and to the rhs of
+// the or.
+
+int globalCounter = 0;
+
+bool nonInlinedNumTypeCheck(Object object) {
+ if (new DateTime.now().millisecondsSinceEpoch == 42) {
+ return nonInlinedNumTypeCheck(object);
+ }
+ return object is num;
+}
+
+main() {
+ var o = [ "foo", 499 ][0];
+
+ if ((o is! num && o.length == 4) ||
+ (nonInlinedNumTypeCheck(o))) {
+ Expect.fail("Type-check failed");
+ }
+}
« no previous file with comments | « tests/compiler/dart2js/simple_inferrer_and_or_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698