Fix bad type-inferrence for is-checks in logical and/or expressions.

tests/language/logical_expression3_test.dart

+// Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.

[ngeoffray, 2014/02/27 10:47:31]

New line?

[floitsch, 2014/02/27 15:25:45]

done. in https://codereview.chromium.org/182373002/

+// Dart test program for testing if statement.

[ngeoffray, 2014/02/27 10:47:31]

Rewrite comment.

[floitsch, 2014/02/27 15:25:45]

done. in https://codereview.chromium.org/182373002/

+
+import "package:expect/expect.dart";
+
+// For logical-or conditions with an and-expression in the lhs, dart2js
+// unconditionally propagated not-is-checks of the logical and to the rhs of
+// the or.
+
+int globalCounter = 0;
+
+bool nonInlinedNumTypeCheck(Object object) {
+  if (new DateTime.now().millisecondsSinceEpoch == 42) {
+    return nonInlinedNumTypeCheck(object);
+  }
+  return object is num;
+}
+
+main() {
+  var o = [ "foo", 499 ][0];
+
+  if ((o is! num && o.length == 4) ||
+      (nonInlinedNumTypeCheck(o))) {
+    Expect.fail("Type-check failed");
+  }
+}