sdk/lib/_internal/compiler/implementation/inferrer/inferrer_visitor.dart - Issue 181783006: Fix bad type-inferrence for is-checks in logical and/or expressions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/inferrer/inferrer_visitor.dart

Issue 181783006: Fix bad type-inferrence for is-checks in logical and/or expressions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Add another test. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/compiler/implementation/inferrer/inferrer_visitor.dart

diff --git a/sdk/lib/_internal/compiler/implementation/inferrer/inferrer_visitor.dart b/sdk/lib/_internal/compiler/implementation/inferrer/inferrer_visitor.dart

index 12cbf777e445c1e2e341e1b0e70fbe74d2cf1720..b0af493d6525139bcf874db6a8970176e43c2f1f 100644

--- a/sdk/lib/_internal/compiler/implementation/inferrer/inferrer_visitor.dart

+++ b/sdk/lib/_internal/compiler/implementation/inferrer/inferrer_visitor.dart

@@ -858,10 +858,10 @@ abstract class InferrerVisitor

} else if ("||" == op.source) {

conditionIsSimple = false;

List<Send> tests = <Send>[];

- handleCondition(node.receiver, tests);

+ bool isSimple = handleCondition(node.receiver, tests);

LocalsHandler<T> saved = locals;

locals = new LocalsHandler<T>.from(locals, node);

- updateIsChecks(tests, usePositive: false);

+ if (isSimple) updateIsChecks(tests, usePositive: false);

bool oldAccumulateIsChecks = accumulateIsChecks;

accumulateIsChecks = false;

isChecks = null;

« no previous file with comments | « no previous file | tests/compiler/dart2js/simple_inferrer_and_or_test.dart » ('j') | tests/language/logical_expression3_test.dart » ('J')