[DevTools] Move callFunctionOn to native

[DevTools] Move callFunctionOn to native

BUG=595206
R=dgozman@chromium.org

Committed: https://crrev.com/d0fe8dc3096d71604f418fe3eae857af502d0ede
Cr-Commit-Position: refs/heads/master@{#382134}

[kozy, 2016-03-17 23:09:35]

Patchset #1 (id:1) has been deleted

[kozy, 2016-03-17 23:10:34]

Dmitry, please take a look!

[kozy, 2016-03-17 23:35:50]

Patchset #1 (id:20001) has been deleted

[dgozman, 2016-03-18 00:38:32]

https://codereview.chromium.org/1809073003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h (right):

https://codereview.chromium.org/1809073003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h:107:
v8::MaybeLocal<v8::Object> callFunctionWithoutArguments(ErrorString*, const
String16& name);
callObjectGetter

https://codereview.chromium.org/1809073003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js
(right):

https://codereview.chromium.org/1809073003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js:712:
remoteObjectAPI: function()
Should pass objectGroup. Can we have a test?

https://codereview.chromium.org/1809073003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
(left):

https://codereview.chromium.org/1809073003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:152:
IgnoreExceptionsScope
ignoreExceptionsScope(doNotPauseOnExceptionsAndMuteConsole.fromMaybe(false) ?
m_debugger : nullptr);
Bring it back.

https://codereview.chromium.org/1809073003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
(right):

https://codereview.chromium.org/1809073003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:170: if
(!compileFunction(errorString, remoteId.get(), expression, objectGroupName,
remoteObjectAPI, result, wasThrown).ToLocal(&function))
Let's compile after resolving arguments.

https://codereview.chromium.org/1809073003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:173:
OwnPtr<v8::Local<v8::Value>[]> argv = adoptArrayPtr(new
v8::Local<v8::Value>[0]);
nullptr

https://codereview.chromium.org/1809073003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:188:
v8::MaybeLocal<v8::Value> maybeResultValue =
function->Call(injectedScript->context(), object, argc, argv.get());
debugger->callFunction()

https://codereview.chromium.org/1809073003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:198:
v8::MaybeLocal<v8::Function> V8RuntimeAgentImpl::compileFunction(ErrorString*
errorString, RemoteObjectIdBase* remoteId, const String16& expression, const
String16& objectGroupName, v8::MaybeLocal<v8::Object> extension,
OwnPtr<protocol::Runtime::RemoteObject>* result, Maybe<bool>* wasThrown)
Can we reuse evaluate() here?

[kozy, 2016-03-18 06:01:56]

All done!

https://codereview.chromium.org/1809073003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h (right):

https://codereview.chromium.org/1809073003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h:107:
v8::MaybeLocal<v8::Object> callFunctionWithoutArguments(ErrorString*, const
String16& name);
On 2016/03/18 00:38:32, dgozman wrote:
> callObjectGetter

callFunctionReturnObject

https://codereview.chromium.org/1809073003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js
(right):

https://codereview.chromium.org/1809073003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js:712:
remoteObjectAPI: function()
On 2016/03/18 00:38:32, dgozman wrote:
> Should pass objectGroup. Can we have a test?

Done.

https://codereview.chromium.org/1809073003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
(left):

https://codereview.chromium.org/1809073003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:152:
IgnoreExceptionsScope
ignoreExceptionsScope(doNotPauseOnExceptionsAndMuteConsole.fromMaybe(false) ?
m_debugger : nullptr);
On 2016/03/18 00:38:32, dgozman wrote:
> Bring it back.

Done.

https://codereview.chromium.org/1809073003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
(right):

https://codereview.chromium.org/1809073003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:170: if
(!compileFunction(errorString, remoteId.get(), expression, objectGroupName,
remoteObjectAPI, result, wasThrown).ToLocal(&function))
On 2016/03/18 00:38:32, dgozman wrote:
> Let's compile after resolving arguments.

Done.

https://codereview.chromium.org/1809073003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:173:
OwnPtr<v8::Local<v8::Value>[]> argv = adoptArrayPtr(new
v8::Local<v8::Value>[0]);
On 2016/03/18 00:38:32, dgozman wrote:
> nullptr

Done.

https://codereview.chromium.org/1809073003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:188:
v8::MaybeLocal<v8::Value> maybeResultValue =
function->Call(injectedScript->context(), object, argc, argv.get());
On 2016/03/18 00:38:32, dgozman wrote:
> debugger->callFunction()

Done.

https://codereview.chromium.org/1809073003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:198:
v8::MaybeLocal<v8::Function> V8RuntimeAgentImpl::compileFunction(ErrorString*
errorString, RemoteObjectIdBase* remoteId, const String16& expression, const
String16& objectGroupName, v8::MaybeLocal<v8::Object> extension,
OwnPtr<protocol::Runtime::RemoteObject>* result, Maybe<bool>* wasThrown)
On 2016/03/18 00:38:32, dgozman wrote:
> Can we reuse evaluate() here?

Extracted evaluateInternal

[dgozman, 2016-03-18 19:51:28]

lgtm

https://codereview.chromium.org/1809073003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp (right):

https://codereview.chromium.org/1809073003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp:395:
v8::Local<v8::Value> scopeExtensionValue = function.call(hadException, false);
result

https://codereview.chromium.org/1809073003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
(right):

https://codereview.chromium.org/1809073003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:188:
v8::MaybeLocal<v8::Value> maybeFunctionValue = evaluateInternal(injectedScript,
doNotPauseOnExceptionsAndMuteConsole.fromMaybe(false), "(" + expression + ")",
remoteObjectAPI);
Let's refetch injectedScript after this evaluate.

[kozy, 2016-03-18 22:14:22]

Patchset #3 (id:80001) has been deleted

[kozy, 2016-03-18 22:14:39]

All done.

https://codereview.chromium.org/1809073003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp (right):

https://codereview.chromium.org/1809073003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp:395:
v8::Local<v8::Value> scopeExtensionValue = function.call(hadException, false);
On 2016/03/18 19:51:28, dgozman wrote:
> result

Done.

https://codereview.chromium.org/1809073003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
(right):

https://codereview.chromium.org/1809073003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:188:
v8::MaybeLocal<v8::Value> maybeFunctionValue = evaluateInternal(injectedScript,
doNotPauseOnExceptionsAndMuteConsole.fromMaybe(false), "(" + expression + ")",
remoteObjectAPI);
On 2016/03/18 19:51:28, dgozman wrote:
> Let's refetch injectedScript after this evaluate.

Done.

[kozy, 2016-03-18 22:14:44]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-03-18 22:14:44]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1809073003/#ps100001
(title: " ")

[commit-bot: I haz the power, 2016-03-18 22:15:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809073003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809073003/100001

[commit-bot: I haz the power, 2016-03-19 00:26:45]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2016-03-19 00:28:21]

Description was changed from

==========
[DevTools] Move callFunctionOn to native

BUG=595206
R=dgozman@chromium.org
==========

to

==========
[DevTools] Move callFunctionOn to native

BUG=595206
R=dgozman@chromium.org

Committed: https://crrev.com/d0fe8dc3096d71604f418fe3eae857af502d0ede
Cr-Commit-Position: refs/heads/master@{#382134}
==========

[commit-bot: I haz the power, 2016-03-19 00:28:23]

Patchset 3 (id:??) landed as
https://crrev.com/d0fe8dc3096d71604f418fe3eae857af502d0ede
Cr-Commit-Position: refs/heads/master@{#382134}