Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js

Issue 1812983002: [DevTools] Move evaluate from InjectedScriptSource.js to native (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move-evaluate-on-call-frame
Patch Set: Removed _callFrameForId Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js
diff --git a/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js b/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js
index 146004b82271736f4c9f1c83798acefb6c0d2af1..13b74c6dc4ab7d5e25fbf2da89b36e93164c69b4 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js
+++ b/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js
@@ -646,28 +646,6 @@ InjectedScript.prototype = {
},
/**
- * @param {string} expression
- * @param {string} objectGroup
- * @param {boolean} injectCommandLineAPI
- * @param {boolean} returnByValue
- * @param {boolean} generatePreview
- * @return {*}
- */
- evaluate: function(expression, objectGroup, injectCommandLineAPI, returnByValue, generatePreview)
- {
- var scopeExtensionForEval = injectCommandLineAPI ? new CommandLineAPI(this._commandLineAPIImpl) : undefined;
- var wrappedResult = InjectedScriptHost.evaluateWithExceptionDetails(expression, scopeExtensionForEval);
- if (objectGroup === "console" && !wrappedResult.exceptionDetails)
- this._lastResult = wrappedResult.result;
- if (!wrappedResult.exceptionDetails) {
- return { wasThrown: false,
- result: this._wrapObject(wrappedResult.result, objectGroup, returnByValue, generatePreview),
- __proto__: null };
- }
- return this._createThrownValue(wrappedResult.result, objectGroup, generatePreview, wrappedResult.exceptionDetails);
- },
-
- /**
* @param {string} objectId
* @param {string} expression
* @param {string} args
@@ -842,21 +820,6 @@ InjectedScript.prototype = {
},
/**
- * @param {!JavaScriptCallFrame} topCallFrame
- * @param {string} callFrameId
- * @return {?JavaScriptCallFrame}
- */
- _callFrameForId: function(topCallFrame, callFrameId)
- {
- var parsedCallFrameId = nullifyObjectProto(/** @type {!Object} */ (InjectedScriptHost.eval("(" + callFrameId + ")")));
- var ordinal = parsedCallFrameId["ordinal"];
- var callFrame = topCallFrame;
- while (--ordinal >= 0 && callFrame)
- callFrame = callFrame.caller;
- return callFrame;
- },
-
- /**
* @param {!Object} objectId
* @return {!Object|symbol|undefined}
*/

Powered by Google App Engine
This is Rietveld 408576698