Issue 18125004: Don't request bug reports when aborting due to --throw-on-error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18125004: Don't request bug reports when aborting due to --throw-on-error. (Closed)

Created:
7 years, 5 months ago by ahe

Modified:
5 years, 10 months ago

Reviewers:
Johnni Winther, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Don't request bug reports when aborting due to --throw-on-error. BUG=http://dartbug.com/11571

Patch Set 1 #

Total comments: 2

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -13 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/apiimpl.dart	View	5 chunks	+14 lines, -0 lines	2 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/dart2js.dart	View	2 chunks	+1 line, -8 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/source_file_provider.dart	View	2 chunks	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/18125004/diff/1/dart/sdk/lib/_internal/compiler/implementation/apiimpl.dart File dart/sdk/lib/_internal/compiler/implementation/apiimpl.dart (right): https://codereview.chromium.org/18125004/diff/1/dart/sdk/lib/_internal/compiler/implementation/apiimpl.dart#newcode233 dart/sdk/lib/_internal/compiler/implementation/apiimpl.dart:233: //path = null; Should we get rid of ...

7 years, 5 months ago (2013-06-28 10:26:50 UTC) #2

lgtm

Expand Messages | Collapse Messages