Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/source_file_provider.dart

Issue 18125004: Don't request bug reports when aborting due to --throw-on-error. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/sdk/lib/_internal/compiler/implementation/source_file_provider.dart
diff --git a/dart/sdk/lib/_internal/compiler/implementation/source_file_provider.dart b/dart/sdk/lib/_internal/compiler/implementation/source_file_provider.dart
index 4cbd6411e0a5e93fc2371d53c0c49a4b6c90a039..db182f3c2420d62be8f4d235852cbbf5bf4cc60d 100644
--- a/dart/sdk/lib/_internal/compiler/implementation/source_file_provider.dart
+++ b/dart/sdk/lib/_internal/compiler/implementation/source_file_provider.dart
@@ -57,7 +57,6 @@ class FormattingDiagnosticHandler {
bool verbose = false;
bool isAborting = false;
bool enableColors = false;
- bool throwOnError = false;
api.Diagnostic lastKind = null;
final int FATAL = api.Diagnostic.CRASH.ordinal | api.Diagnostic.ERROR.ordinal;
@@ -128,10 +127,6 @@ class FormattingDiagnosticHandler {
}
print(file.getLocationMessage(color(message), begin, end, true, color));
}
- if (fatal && throwOnError) {
- isAborting = true;
- throw new AbortLeg(message);
- }
}
void call(Uri uri, int begin, int end, String message, api.Diagnostic kind) {

Powered by Google App Engine
This is Rietveld 408576698