Don't request bug reports when aborting due to --throw-on-error.

dart/sdk/lib/_internal/compiler/implementation/apiimpl.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library leg_apiimpl;
 
 import 'dart:async';
 
 import '../compiler.dart' as api;
 import 'dart2jslib.dart' as leg;
 import 'tree/tree.dart' as tree;
 import 'elements/elements.dart' as elements;
 import 'ssa/tracer.dart' as ssa;
 import '../../libraries.dart';
 import 'source_file.dart';
 
 class Compiler extends leg.Compiler {
   api.ReadStringFromUri provider;
   api.DiagnosticHandler handler;
   final Uri libraryRoot;
   final Uri packageRoot;
   List<String> options;
   bool mockableLibraryUsed = false;
   final Set<String> allowedLibraryCategories;
+  final bool throwOnError;
 
   Compiler(this.provider,
            api.CompilerOutputProvider outputProvider,
            this.handler,
            this.libraryRoot,
            this.packageRoot,
            List<String> options)
       : this.options = options,
         this.allowedLibraryCategories = getAllowedLibraryCategories(options),
+        this.throwOnError = hasOption(options, '--throw-on-error'),
         super(
             tracer: new ssa.HTracer(
                 ssa.GENERATE_SSA_TRACE ? outputProvider('dart', 'cfg') : null),
             outputProvider: outputProvider,
             enableTypeAssertions: hasOption(options, '--enable-checked-mode'),
             enableUserAssertions: hasOption(options, '--enable-checked-mode'),
             trustTypeAnnotations:
                 hasOption(options, '--trust-type-annotations'),
             enableMinification: hasOption(options, '--minify'),
             enableNativeLiveTypeAnalysis:
@@ skipping 177 matching lines @@
         if (node != null && importingLibrary != null) {
           reportDiagnostic(spanFromNode(node),
               'Error: Internal library $resolvedUri is not accessible from '
               '${importingLibrary.canonicalUri}.',
               api.Diagnostic.ERROR);
         } else {
           reportDiagnostic(null,
               'Error: Internal library $resolvedUri is not accessible.',
               api.Diagnostic.ERROR);
         }
         //path = null;

[kasperl, 2013/06/28 10:26:50]

Should we get rid of this line?

       }
     }
     if (path == null) {
       if (node != null) {
         reportError(node, 'library not found ${resolvedUri}');
       } else {
         reportDiagnostic(null, 'library not found ${resolvedUri}',
                          api.Diagnostic.ERROR);
       }
       return null;
@@ skipping 24 matching lines @@
       log('${task.name} took ${task.timing}msec');
     }
     int total = totalCompileTime.elapsedMilliseconds;
     log('Total compile-time ${total}msec;'
         ' unaccounted ${total - cumulated}msec');
     return success;
   }
 
   void reportDiagnostic(leg.SourceSpan span, String message,
                         api.Diagnostic kind) {
+    bool isFatal = false;
     if (identical(kind, api.Diagnostic.ERROR)
         || identical(kind, api.Diagnostic.CRASH)) {
       compilationFailed = true;
+      isFatal = true;
     }
     // [:span.uri:] might be [:null:] in case of a [Script] with no [uri]. For
     // instance in the [Types] constructor in typechecker.dart.
     if (span == null || span.uri == null) {
       handler(null, null, null, message, kind);
     } else {
       handler(translateUri(span.uri, null), span.begin, span.end,
               message, kind);
     }
+    if (isFatal && throwOnError) {
+      hasCrashed = true;

[kasperl, 2013/06/28 10:26:50]

Add a comment here? Rename flag to make it clear that setting it to true make
the framework stop asking the user to report the crash?

+      throw new AbortCompilation(message);
+    }
   }
 
   bool get isMockCompilation {
     return mockableLibraryUsed
       && (options.indexOf('--allow-mock-compilation') != -1);
   }
 }
+
+class AbortCompilation {
+  final message;
+  AbortCompilation(this.message);
+  toString() => 'Aborted due to --throw-on-error: $message';
+}